Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useKeyDown: propagate event's keycode to handler #752

Merged
merged 3 commits into from
Apr 9, 2020
Merged

useKeyDown: propagate event's keycode to handler #752

merged 3 commits into from
Apr 9, 2020

Conversation

sohkai
Copy link
Contributor

@sohkai sohkai commented Apr 9, 2020

In cases where there are multiple keycodes listened to, this allows the handler to know which key was pressed and how to handle it.

@sohkai sohkai requested a review from bpierre April 9, 2020 09:01
bpierre
bpierre reviewed Apr 9, 2020
View reviewed changes
src/hooks/useKeyDown.js Outdated Show resolved Hide resolved
@sohkai sohkai mentioned this pull request Apr 9, 2020
Closed
bpierre
bpierre approved these changes Apr 9, 2020
View reviewed changes
Copy link
Contributor

@bpierre bpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sohkai sohkai merged commit 339a1be into master Apr 9, 2020
@sohkai sohkai deleted the update-use-keydown branch April 9, 2020 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpierre bpierre bpierre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sohkai @bpierre