Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix critical dependency issue #72

Merged

Conversation

bluelakee02
Copy link
Contributor

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[X ] Bug fix
[ ] New feature
[ ] Other, please explain:

What changes did you make? (Give an overview)

I fixed app router on new next

Which issue (if any) does this pull request address?
#9

next-translate

Is there anything you'd like reviewers to focus on?

Copy link
Owner

@aralroca aralroca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for solving it by doing this transpilation.

@aralroca
Copy link
Owner

@bluelakee02 can you solve the failing tests? Probably you only need to update the snapshots! Thanks!

@bluelakee02
Copy link
Contributor Author

@aralroca sure, I am on it, sorry about that :)

@bluelakee02
Copy link
Contributor Author

@aralroca pushed

@aralroca aralroca merged commit e26c934 into aralroca:main Oct 14, 2023
6 checks passed
@aralroca
Copy link
Owner

@all-contributors please add @bluelakee02 for code

@allcontributors
Copy link
Contributor

@aralroca

I've put up a pull request to add @bluelakee02! 🎉

@aralroca
Copy link
Owner

@bluelakee02 I already did the release of the patch version, thanks for the contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants