Change peer dependency for React #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use React 18.0.0 or any version greater as a peer dependency.
|
Good job opening the PR so quickly. I was just about to create an issue. For the reference, the change that broke down peerdeps |
aralroca
approved these changes
Jun 19, 2023
|
Thanks for the fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use React 18.0.0 or any version greater as a peer dependency.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix
[ ] New feature
[ X ] Other, please explain:
What changes did you make? (Give an overview)
In package.json I changed the peer dependency for React to be
>= 18.0.0to allow for newer versions of React.Which issue (if any) does this pull request address?
If you try to install Next Translate with
npm install next-translatewhile having React already added as a dependency with the latest version (18.2.0), installation fails because the dependency tree cannot be resolved. It also happens if you are using Next 13.4.3, which has a React dependency of^18.2.0.Is there anything you'd like reviewers to focus on?
Test the current package.json with React 18.2.0 or Next 13.4.3 as an existing dependency.