-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Improve BIDS compatibility of PetLinear
CAPS output
#935
[ENH] Improve BIDS compatibility of PetLinear
CAPS output
#935
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with a few comments for posterity.
I have got also comments on the data PR.
def _rename_transformation_into_caps(entities: str, filename: str) -> str: | ||
"""Rename into CAPS transformation file.""" | ||
return _rename(filename, entities, "_space-T1w_rigid.mat") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a comment that we could achieve further compliance by adopting BEP014 which specifies a naming scheme for transformation files, i.e.
<participant_id>/
<session_id>/
xfm/
<participant_id>_<session_id>_from-T1w_to-MNI152NLin2009cSym_mode-image_xfm.mat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would probably require more surgery to t1-linear
and pet-linear
though, so it's probably better to leave it for another time. It was just a reminder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, let's keep that for another PR.
Thanks for the reminder !
The general idea of this PR is to improve the BIDS compliance of the
PETLinear
pipeline.The current output looks like this:
Where the suffix
pet
appears after the tracer while it shouldn't.This PR proposes to:
PETLinear
utility functionrename_into_caps
PETLinear
pipeline accordinglySince we are changing the output, this PR needs the following data PR : https://github.com/aramis-lab/clinica_data_ci/pull/47