Fix bug that \r\n are visible at the end of lines.

[henry0312]

No description provided.

[aramk]

I've fixed this in 1.9.9, it was caused by using single quotes. That line is to ensure that any line using \r or \n uses \r\n so that it's windows compatible as well.

[henry0312]

NO, NO!
Your change, "\r\n" is wrong.
This causes unnecessary empty lines on both Windows and Mac OS X, I confirmed.

[aramk]

The regex "(\r(?!\n))|((?<!\r)\n)" doesn't create line breaks or carriage returns, it merely converts \r and \n to \r\n, but only if they aren't \r\n. If there's still a problem could you give an example?

[henry0312]

Test – Crayon Syntax Highlighter | Re: no subject
http://henry.animeo.jp/wp/?p=1701

Please see.
line 2 and 8 are unnecessary empty lines.

I used the original code, http://privatepaste.com/056b54d69c

by the way, I use WordPress 3.4.

[aramk]

Sorry about that, fixed in the last commit.

[henry0312]

OK, the latest commit seems fine ;)

[aramk]

Great! The problem was I hadn't accounted the \r\n into the code that split lines (It used $, which comes after \r and before \n)

[henry0312]

This bug seems to appear again after commit 82d11a5

Test – Crayon Syntax Highlighter
http://henry.animeo.jp/wp/?p=1716

Please see.
line 2 and 8 are unnecessary empty lines.

I used the original code, http://privatepaste.com/056b54d69c

[aramk]

Have a look at the latest commits. I'm going to work with git from now on rather than svn and only use it for releases. I'm making a new branch for the tag editor.

[henry0312]

I pulled dba1714, but this problem isn't solved.

[aramk]

Sorry, I discovered the cause after I wrote that. Try 071c38b.

[henry0312]

Fixed this problem with 071c38b :D

[aramk]

Great, in the future I'll make sure the repo is handled better now that I'm using Git primarily.

[henry0312]

All right.
I will use github code , not archives on http://wordpress.org/extend/plugins/crayon-syntax-highlighter/

[aramk]

Only if something is broken. Consider the tags on svn official and everything on github as development.