Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement insert and improve select #106

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

jjeffcaii
Copy link
Contributor

What this PR does:

  1. implement INSERT
  2. use the latest parser
  3. improve SELECT, support full-scan switch

Which issue(s) this PR fixes:

Fixes #101

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@jjeffcaii
Copy link
Contributor Author

PS: merge it after #91

@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2022

Codecov Report

Merging #106 (31fd977) into master (768d18b) will increase coverage by 0.98%.
The diff coverage is 51.69%.

@@            Coverage Diff             @@
##           master     #106      +/-   ##
==========================================
+ Coverage   34.45%   35.43%   +0.98%     
==========================================
  Files          69       69              
  Lines       10795    10944     +149     
==========================================
+ Hits         3719     3878     +159     
+ Misses       6637     6621      -16     
- Partials      439      445       +6     
Impacted Files Coverage Δ
pkg/executor/redirect.go 13.38% <0.00%> (-0.49%) ⬇️
pkg/mysql/server.go 0.00% <0.00%> (ø)
pkg/runtime/ast/insert.go 32.94% <0.00%> (-2.96%) ⬇️
pkg/runtime/optimize/sharder.go 26.19% <0.00%> (-0.10%) ⬇️
pkg/runtime/runtime.go 3.33% <0.00%> (-0.11%) ⬇️
pkg/proto/rule/topology.go 92.59% <66.66%> (-7.41%) ⬇️
pkg/runtime/optimize/optimizer.go 55.23% <66.66%> (+18.39%) ⬆️
pkg/proto/rule/database_table.go 78.45% <70.58%> (+3.15%) ⬆️
pkg/runtime/ast/ast.go 83.29% <87.50%> (+0.04%) ⬆️
pkg/runtime/rule/evaluator.go 22.17% <100.00%> (+0.16%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 768d18b...31fd977. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When execute "select * from student" mysql/server.go:161 mysql_server caught panic:
6 participants