Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: impl shadow match hint rule #363

Merged
merged 1 commit into from
Aug 19, 2022
Merged

feature: impl shadow match hint rule #363

merged 1 commit into from
Aug 19, 2022

Conversation

Lvnszn
Copy link
Contributor

@Lvnszn Lvnszn commented Aug 16, 2022 •
edited by dongzl
Loading

What this PR does:

Which issue(s) this PR fixes:

ref #174

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2022 •
edited
Loading

Codecov Report

Merging #363 (7790aff) into master (dc102cc) will decrease coverage by 0.14%.
The diff coverage is 17.39%.

@@            Coverage Diff             @@
##           master     #363      +/-   ##
==========================================
- Coverage   39.46%   39.32%   -0.15%     
==========================================
  Files         111      111              
  Lines       14764    14804      +40     
==========================================
- Hits         5827     5822       -5     
- Misses       8222     8263      +41     
- Partials      715      719       +4
Impacted Files Coverage Δ
pkg/config/api.go 100.00% <ø> (ø)
pkg/config/config.go 0.00% <0.00%> (ø)
pkg/proto/rule/shadow.go 0.00% <0.00%> (ø)
pkg/runtime/namespace/command.go 25.00% <0.00%> (-1.93%) ⬇️
pkg/runtime/optimize/dml/select.go 0.68% <ø> (ø)
pkg/runtime/runtime.go 2.60% <0.00%> (-0.02%) ⬇️
pkg/boot/discovery.go 61.69% <8.33%> (-2.71%) ⬇️
pkg/runtime/namespace/namespace.go 51.63% <16.66%> (-1.81%) ⬇️
pkg/boot/boot.go 57.83% <70.00%> (+1.07%) ⬆️
pkg/runtime/optimize/optimizer.go 35.71% <100.00%> (+1.16%) ⬆️
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dongzl dongzl added the shadow Shadow table. label Aug 16, 2022
@Lvnszn Lvnszn force-pushed the feature_value_match branch 4 times, most recently from 1600ba8 to 7790aff Compare August 16, 2022 10:09
@dongzl dongzl changed the base branch from master to feat/shadow August 16, 2022 15:01
@Lvnszn Lvnszn changed the title [WIP] feature: impl shadow match value rule feature: impl shadow match hint rule Aug 16, 2022
@Lvnszn Lvnszn force-pushed the feature_value_match branch 3 times, most recently from 157bc57 to ccc269c Compare August 17, 2022 03:24
dongzl
dongzl requested changes Aug 17, 2022
View reviewed changes
conf/config.yaml Outdated Show resolved Hide resolved
integration_test/scripts/shadow/init.sql Outdated Show resolved Hide resolved
pkg/runtime/optimize/dml/delete.go Outdated Show resolved Hide resolved
pkg/runtime/optimize/dml/insert.go Outdated Show resolved Hide resolved
pkg/runtime/optimize/dml/select.go Outdated Show resolved Hide resolved
pkg/runtime/optimize/dml/update.go Outdated Show resolved Hide resolved
@dongzl
Copy link
Contributor

dongzl commented Aug 17, 2022

  • suggest keep the name employee_shadow, employee_show easy to confuse.
  • format import. this tool
go get -u github.com/dubbogo/tools/cmd/imports-formatter

imports-formatter

@Lvnszn Lvnszn force-pushed the feature_value_match branch 5 times, most recently from 0350767 to 6940714 Compare August 18, 2022 03:02
@Lvnszn Lvnszn requested a review from dongzl August 18, 2022 03:25
@Lvnszn Lvnszn force-pushed the feature_value_match branch 3 times, most recently from fc765ae to 38d6dda Compare August 18, 2022 08:43
jjeffcaii
jjeffcaii reviewed Aug 18, 2022
View reviewed changes
pkg/proto/rule/shadow.go Outdated Show resolved Hide resolved
jjeffcaii
jjeffcaii approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@jjeffcaii jjeffcaii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

baerwang
baerwang reviewed Aug 19, 2022
View reviewed changes
pkg/boot/discovery.go Outdated Show resolved Hide resolved
pkg/proto/rule/shadow.go Show resolved Hide resolved
@Lvnszn Lvnszn requested a review from baerwang August 19, 2022 03:33
georgehao
georgehao reviewed Aug 19, 2022
View reviewed changes
pkg/proto/rule/shadow.go Outdated Show resolved Hide resolved
@Lvnszn Lvnszn requested review from georgehao and removed request for baerwang August 19, 2022 04:04
@AlexStocks AlexStocks merged commit 976e1a8 into arana-db:feat/shadow Aug 19, 2022
@dongzl dongzl mentioned this pull request Aug 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baerwang baerwang baerwang left review comments

@jjeffcaii jjeffcaii jjeffcaii approved these changes

@dongzl dongzl dongzl approved these changes

@georgehao georgehao georgehao approved these changes

@AlexStocks AlexStocks AlexStocks approved these changes

@binbin0325 binbin0325 binbin0325 approved these changes

Assignees
No one assigned
Labels
shadow Shadow table.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Lvnszn @codecov-commenter @dongzl @jjeffcaii @georgehao @AlexStocks @binbin0325 @baerwang