fix: connection leak when concurrent updates #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjeffcaii
requested review from
dongzl,
georgehao,
AlexStocks,
PangXing,
wang1309,
maronghe,
Mulavar,
chuntaojun,
binbin0325,
JasonZhang95,
luky116 and
gongna-au
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #669 +/- ##
==========================================
+ Coverage 36.79% 36.81% +0.01%
==========================================
Files 204 204
Lines 22428 22724 +296
==========================================
+ Hits 8253 8366 +113
- Misses 13258 13427 +169
- Partials 917 931 +14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
In short words, we close the request-response lifecycle too soon when executing
|
AlexStocks
reviewed
Apr 6, 2023
| @@ -772,7 +774,7 @@ func (c *Conn) writeErrorPacket(errorCode uint16, sqlState string, format string | |||
| sqlState = mysql.SSUnknownSQLState | |||
| } | |||
| if len(sqlState) != 5 { | |||
| panic("sqlState has to be 5 characters long") | |||
| panic(fmt.Sprintf("sqlState has to be 5 characters long, actual is %d!", len(sqlState))) | |||
There was a problem hiding this comment.
不能返回 error 吗？panic 不能轻易启用。
dongzl
approved these changes
Apr 6, 2023
chuntaojun
approved these changes
Apr 6, 2023
PangXing
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes #639
Special notes for your reviewer:
Does this PR introduce a user-facing change?: