Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit test for function (#746) #756

Merged
merged 2 commits into from
Sep 16, 2023
Merged

Conversation

csynineyang
Copy link
Contributor

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2023

Codecov Report

Patch coverage: 83.33% and project coverage change: +0.93% 🎉

Comparison is base (304e9ff) 38.38% compared to head (4a0d088) 39.32%.
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #756      +/-   ##
==========================================
+ Coverage   38.38%   39.32%   +0.93%     
==========================================
  Files         254      259       +5     
  Lines       26359    26502     +143     
==========================================
+ Hits        10119    10422     +303     
+ Misses      15121    14946     -175     
- Partials     1119     1134      +15     
Files Changed Coverage Δ
pkg/runtime/namespace/namespace.go 67.59% <83.33%> (+20.33%) ⬆️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dongzl dongzl added the test Unit test. label Sep 2, 2023
@dongzl dongzl added this to the 0.2.0 milestone Sep 2, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@maronghe maronghe merged commit b40e2af into arana-db:master Sep 16, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Unit test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants