Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]fix: show tables #762

Closed
wants to merge 2 commits into from
Closed

Conversation

zxy-lgtm
Copy link
Contributor

What this PR does:

Fix show tables errors, supports the same behavior as mysql.
ref: ttps://dev.mysql.com/doc/refman/8.0/en/show-tables.html

Which issue(s) this PR fixes:

Fixes #677

Special notes for your reviewer:

arana-db/parser#39

Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2023

Codecov Report

Patch coverage: 75.00% and project coverage change: +0.52% 🎉

Comparison is base (ca6a25c) 38.80% compared to head (518293a) 39.32%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #762      +/-   ##
==========================================
+ Coverage   38.80%   39.32%   +0.52%     
==========================================
  Files         259      259              
  Lines       26468    26812     +344     
==========================================
+ Hits        10271    10544     +273     
- Misses      15075    15135      +60     
- Partials     1122     1133      +11     
Files Changed Coverage Δ
pkg/runtime/plan/dal/show_tables.go 0.00% <0.00%> (ø)
pkg/runtime/ast/show.go 37.23% <45.00%> (+7.62%) ⬆️
pkg/proto/rule/rule.go 59.72% <100.00%> (+8.93%) ⬆️
pkg/runtime/ast/ast.go 71.55% <100.00%> (+3.22%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Sep 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

@dongzl dongzl added the bug Something isn't working label Sep 15, 2023
@dongzl dongzl added this to the 0.2.0 milestone Sep 15, 2023
@jjeffcaii
Copy link
Contributor

It seems conflicts with the PR #761.

@dongzl dongzl changed the title fix: show tables [WIP]fix: show tables Sep 16, 2023
@dongzl dongzl modified the milestones: 0.2.0, 0.3.0 Oct 10, 2023
@dongzl dongzl closed this Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] fix show tables xxx statement error.
5 participants