test: etcd ut #815
Merged
test: etcd ut #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information |
|
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #815 +/- ##
==========================================
- Coverage 40.46% 40.12% -0.35%
==========================================
Files 265 265
Lines 26711 26730 +19
==========================================
- Hits 10809 10725 -84
- Misses 14739 14852 +113
+ Partials 1163 1153 -10 ☔ View full report in Codecov by Sentry. |
dongzl
reviewed
Jan 22, 2024
| @@ -92,7 +88,7 @@ func (c *storeOperate) Get(key config.PathKey) ([]byte, error) { | |||
| } | |||
|
|
|||
| if len(resp.Kvs) == 0 { | |||
| return nil, err | |||
| return nil, nil | |||
There was a problem hiding this comment.
err pre contion aleady return
dongzl
approved these changes
Jan 26, 2024
maronghe
approved these changes
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes #790
Special notes for your reviewer:
Does this PR introduce a user-facing change?: