Simplify composer installation instructions #200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You shouldn't document how to use composer in this library. Assume composer knowledge, and maybe add a link to its docs if you feel instructions aren't clear enough. Check [any](https://github.com/thephpleague/flysystem) [other](https://github.com/laravel/socialite) [php](https://github.com/zendframework/zend-diactoros/blob/master/doc/book/install.md) [library](https://symfony.com/doc/current/components/using_components.html) out there for conventions on composer docs. Previous docs were too verbose and people with knowledge of composer would have to dig deep to find the package name (or end up looking for it in your `composer.json` instead of the README file.)
|
Thanks for providing this patch! I am happy to accept the patch, but for legal reasons we need you to fill out and sign our Contributor License Agreement (CLA). You can scan and email the CLA PDF file to cla@arangodb.com or send it via fax to +49-221-2722999-88. |
|
Hi @guiwoda. Thanks for this PR. |
|
You can commit separately, I completely forgot about this and I'm not using
the library now, so I don't think I'll be sending PRs this way anyway.
El vie., 10 de feb. de 2017 08:45, Frank Mayer <notifications@github.com>
escribió:
… Hi @guiwoda <https://github.com/guiwoda>. Thanks for this PR.
Can we expect a signed CLA from you in order to be able to merge this PR
or should I go ahead and make the necessary changes in a separate commit?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#200 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABjNybvGHIIj7pIo11qjHyhJM4XPDsEZks5rbE3JgaJpZM4KlQuo>
.
|
|
This was implemented and further changed in a separate commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You shouldn't document how to use composer in this library.
Assume composer knowledge, and maybe add a link to its docs if you feel instructions aren't clear enough.
Check any other php library out there for conventions on composer docs.
Previous docs were too verbose and people with knowledge of composer would have to dig deep to find the package name (or end up looking for it in your
composer.jsoninstead of the README file.)