Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove retry logic for fuerte connections #20908

Closed
wants to merge 6 commits into from

Conversation

jsteemann
Copy link
Contributor

Scope & Purpose

Backport of #20907

  • Fix connection retry attempts for cluster-internal TLS connections that ran
    into the 15 seconds timeout during the connection establishing attempt.
    In this case, the low-level socket was repurposed, but not reset properly.
    This could leave the connection in an improper state and lead to callbacks
    for some requests to not being called as expected.
    The fix is to remove the retry logic, and instead prolong the connection
    timeout to a multiple of the previous timeout value.
  • 💩 Bugfix
  • 🍕 New feature
  • 🔥 Performance improvement
  • 🔨 Refactoring/simplification

Checklist

  • Tests
    • Regression tests
    • C++ Unit tests
    • integration tests
    • resilience tests
  • 📖 CHANGELOG entry made
  • 📚 documentation written (release notes, API changes, ...)
  • Backports
    • Backport for 3.12.0: -
    • Backport for 3.11: -
    • Backport for 3.10: -

Related Information

  • Docs PR:
  • Enterprise PR:
  • GitHub issue / Jira ticket:
  • Design document:

@jsteemann jsteemann added this to the 3.11.7.4 milestone May 7, 2024
@cla-bot cla-bot bot added the cla-signed label May 7, 2024
@jsteemann
Copy link
Contributor Author

jsteemann commented May 10, 2024

We will abandon this solution without retries in favor of a solution with retries (#20877 and the likes).

@KVS85 KVS85 modified the milestones: 3.11.7.4, 3.11.7.5 May 10, 2024
@jsteemann jsteemann closed this May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants