Report proper error for arangoimp create collection failure. #3127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ObiWahn
added a commit
that referenced
this pull request
Sep 4, 2017
…ture/planning-query-result-cache * 'devel' of https://github.com/arangodb/arangodb: Proper defaults Failed regex rename no more real Publish a basic but hopefully working pipeline dont sleep at start (#3164) Bug fix/fixes 2808 (#3156) Improvements to CachedValue internals and handling. (#3126) Fixing error reporting in arangoimp (#3153) Don't use global static variables as collection caches - this may cau… (#3150) Added a more descriptiove documentation about ArangoRestore when using authentication and UserManagement. As required by: #3023 (#3148) Bug fix/issue 3106 orphans in general graph (#3147) added resilience to pipelince for cluster tests (#3140) fixed a bug in create collection in cluster, where transaction result was not checked for success before access (#3137) Fix HTTP Foxx API Json parsing (#3129) Report proper error for arangoimp create collection failure. (#3127) Bug fix/foxx queue auth (devel) (#3122) fixed wrong ui cluster health information (#3151)
fceller
deleted the
feature/report-proper-error-for-arangoimp-create-collection-fail
branch
ObiWahn
added a commit
that referenced
this pull request
Dec 21, 2017
commit 6e7a1d1a4d8aa32f43f1683cdcfda7e91d1087bd
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Thu Sep 28 10:12:14 2017 +0200
append shardid to query string
commit a8feac0
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Thu Sep 28 09:29:10 2017 +0200
add missing items at shutdown and fix skipsome
commit 31ddbc1
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Mon Sep 25 14:01:45 2017 +0200
make use of cachecheck in RestAqlHandler, change logging and fix other
commit 1260768
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Mon Sep 25 12:56:52 2017 +0200
add invalidation counter to query cache
commit 77740eb
Merge: 31213ef 4d20d50
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Tue Sep 12 09:33:49 2017 +0200
Merge branch 'devel' of https://github.com/arangodb/arangodb into feature/planning-query-result-cache
* 'devel' of https://github.com/arangodb/arangodb:
fix cleanup
Remove override of testmatrix (build only linux)
Fix Foxx queue test (#3219)
commit 31213ef
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Mon Sep 11 22:08:19 2017 +0200
add custom type for ranges and stringification for more nodes
as well as emplaceValue() to AqlItemBlock
commit e9230ca
Merge: c9d9c0e cf66414
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Mon Sep 11 11:35:38 2017 +0200
Merge branch 'devel' of https://github.com/arangodb/arangodb into feature/planning-query-result-cache
* 'devel' of https://github.com/arangodb/arangodb:
fix compilation in non-maintainer-mode
Feature/jenkins pipeline (#3218)
increase cache lifetime for cluster selectivity estimates
fixed a bug, where when servers failed, when also agency leadership c… (#3189)
added new test suite authentication_server
No access collections Improvements (#3190)
removing unnecessary rate limiting (#3194)
fix duplicate mutex (#3215)
updated CHANGELOG
Feature/jenkins pipeline (#3210)
Aardvark: Disable vertical line in query explain editor
commit c9d9c0e
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Fri Sep 8 17:01:03 2017 +0200
query result cache: recreate AqlItemBlocks from cache before sending
commit 8299618
Merge: aa35e84 98e6484
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Wed Sep 6 15:35:58 2017 +0200
Merge branch 'devel' of https://github.com/arangodb/arangodb into feature/planning-query-result-cache
* 'devel' of https://github.com/arangodb/arangodb:
Fix bug in RocksDB incremental collection sync for empty colls. (#3207)
commit aa35e84
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Wed Sep 6 15:34:47 2017 +0200
query result cache: fix ast stringification
commit 2bf05bd
Merge: 94f17bc eacad99
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Tue Sep 5 08:44:11 2017 +0200
Merge branch 'devel' of https://github.com/arangodb/arangodb into feature/planning-query-result-cache
* 'devel' of https://github.com/arangodb/arangodb:
Bug fix/fixes 0409 (#3199)
give usefull errors in case of rocksdb init aborting with 'IOError' w… (#3178)
Handle non-existing user config in RestUserHandler (#3200)
Bug fix/truncate geo (#3173)
fix deadlocks in cluster traversals (#3198)
execute DOCUMENT function via CXX on coordinator in cluster mode (#3196)
Bug fix/fixes 0109 (#3191)
commit 94f17bc
Merge: 070b0aa 76dbc2e
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Mon Sep 4 17:03:20 2017 +0200
Merge branch 'devel' of https://github.com/arangodb/arangodb into feature/planning-query-result-cache
* 'devel' of https://github.com/arangodb/arangodb:
Add tick to batch result. (#3195)
added option `--server.check-max-memory-mappings` (#3185)
removed useless explain
fix windows ifdefs
fixes for MSVC
potential fix for MSVC
fix clang warnings
Bug fix/enterprise build quick fix (#3183)
fix broken enterprise build (#3181)
fix systemd issues when reinstalling a package
commit 070b0aa
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Mon Sep 4 17:02:36 2017 +0200
cluster query cache: first items are returned from the cache
commit 93b4d87
Merge: 5f46fa1 dfb5630
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Fri Sep 1 09:38:34 2017 +0200
Merge branch 'devel' of https://github.com/arangodb/arangodb into feature/planning-query-result-cache
* 'devel' of https://github.com/arangodb/arangodb:
PUBLIC enterprise definitions
Feature/unique vpack index lookup performance improvements with rocksdbkey optimizations (#3123)
correct tempdir under windows
Making foxx-queues test deterministic (#3172)
Optimizations for Caches and Graph Traversals (#3169)
Merge with latest changes in improve-jenkins
Fix compiler warnings and needlessly failing catch tests. (#3171)
Bug fix/unordered map changes order in catch tests (#3175)
be more ignorant about existing or missing directories on startup / cleanup.
fix upgrade exit codes
fix postinst script of debian package
commit 5f46fa1
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Fri Sep 1 09:37:53 2017 +0200
query result cache: implement code in RestHandler
commit 8722da5
Merge: fa41b11 86db523
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Thu Aug 31 07:22:18 2017 +0200
Merge branch 'devel' of https://github.com/arangodb/arangodb into feature/planning-query-result-cache
* 'devel' of https://github.com/arangodb/arangodb:
fix compile warning in non-maintainer mode
windows implementation was missing
Feature/cluster inventory version (#3152)
fixed some MSVC warnings
rename scripts
change to devel
commit fa41b11
Merge: 7ba5dc8 e7a606a
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Wed Aug 30 12:10:17 2017 +0200
Merge branch 'devel' of https://github.com/arangodb/arangodb into feature/planning-query-result-cache
* 'devel' of https://github.com/arangodb/arangodb:
updated CHANGELOG
commit 7ba5dc8
Merge: 85eddc3 94e9744
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Wed Aug 30 12:04:13 2017 +0200
Merge branch 'devel' of https://github.com/arangodb/arangodb into feature/planning-query-result-cache
* 'devel' of https://github.com/arangodb/arangodb:
order of free and free2 changed with use of unordered_multimap vs multimap (#3168)
jslint (#3167)
Cleanup after each testrun (#3109)
Feature/planning 499 different error codes for version check (#3118)
Remove attribute option for arangoimp (#3141)
Bug fix/agency mt fixes (#3158)
When the user entered non-matching passwords, we need to go back two steps so he can re-enter the first password too. (#3155)
Changed some tasks to post through Scheduler instead of directly. (#3159)
Bug fix/scheduling et al (#3161)
commit 85eddc3
Merge: f5c99f7 ec2191c
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Wed Aug 30 08:35:52 2017 +0200
Merge branch 'devel' of https://github.com/arangodb/arangodb into feature/planning-query-result-cache
* 'devel' of https://github.com/arangodb/arangodb:
Proper defaults
Failed regex
rename
no more real
Publish a basic but hopefully working pipeline
dont sleep at start (#3164)
Bug fix/fixes 2808 (#3156)
Improvements to CachedValue internals and handling. (#3126)
Fixing error reporting in arangoimp (#3153)
Don't use global static variables as collection caches - this may cau… (#3150)
Added a more descriptiove documentation about ArangoRestore when using authentication and UserManagement. As required by: #3023 (#3148)
Bug fix/issue 3106 orphans in general graph (#3147)
added resilience to pipelince for cluster tests (#3140)
fixed a bug in create collection in cluster, where transaction result was not checked for success before access (#3137)
Fix HTTP Foxx API Json parsing (#3129)
Report proper error for arangoimp create collection failure. (#3127)
Bug fix/foxx queue auth (devel) (#3122)
fixed wrong ui cluster health information (#3151)
commit f5c99f7
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Wed Aug 30 08:16:42 2017 +0200
query result cache: add cacheUse() function to AqlQuery
commit ad103f1
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Tue Aug 29 14:47:00 2017 +0200
query result cache: prepare caching in resthandler
commit 10d500a
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Tue Aug 29 10:16:13 2017 +0200
increment version number in documentation (manpages)
commit f22f838
Merge: b3d2316 7d72f13
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Mon Aug 28 10:44:19 2017 +0200
Merge branch 'devel' of https://github.com/arangodb/arangodb into feature/planning-query-result-cache
* 'devel' of https://github.com/arangodb/arangodb:
handle the NODE_MODULES_DIR via a global variable.
cleanup our workplace before we do a distbuild
remove obsolete, dysfunctional endpoints (#3135)
No access collections (#3088)
Adding missing changelog / breaking upgrades entries (#3128)
added missing CHANGELOG entry (#3124)
Bug fix/scheduler delete (#3077)
remove directory first, so we don't copy it into a sub directory
use indices on our foxx queues queries; Migrate queries away from aqb… (#3101)
when running the client tests on an already running server we have to specify the server root directory. (#3102)
Fix foxx queue test (#3119)
Bug fix/issues 2308 (#3117)
a few simplifications and extensions (#3115)
fight msvc warnings (#3112)
Feature/unique vpack index lookup performance improvements (#3087)
commit b3d2316
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Fri Aug 25 15:43:27 2017 +0200
Add fakequery string to creation of queries on DBServers
commit fa5564e
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Fri Aug 25 11:48:43 2017 +0200
Add fakequery string to query when receiving via RestAqlHandler
commit 667bc35
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Fri Aug 25 11:47:59 2017 +0200
send query string to DBServers
commit 279e9bd
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Fri Aug 25 10:21:56 2017 +0200
get fake stringification working for basic cases
commit 08b80bf
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Thu Aug 24 16:57:48 2017 +0200
query result cache: add fake stringify for some nodes
commit 4d2ba5e
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Thu Aug 24 12:04:21 2017 +0200
query result cache: prepare hash value creation
commit da40a02
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Thu Aug 24 10:07:39 2017 +0200
result cache: update functiosn in v8-vocbase
commit f502af8
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Thu Aug 24 09:46:33 2017 +0200
result cache: move code (share with v8) and implement clear()
commit c529c24
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Thu Aug 24 07:50:34 2017 +0200
add code for properties
ObiWahn
added a commit
that referenced
this pull request
Dec 22, 2017
commit 6e7a1d1a4d8aa32f43f1683cdcfda7e91d1087bd
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Thu Sep 28 10:12:14 2017 +0200
append shardid to query string
commit a8feac0
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Thu Sep 28 09:29:10 2017 +0200
add missing items at shutdown and fix skipsome
commit 31ddbc1
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Mon Sep 25 14:01:45 2017 +0200
make use of cachecheck in RestAqlHandler, change logging and fix other
commit 1260768
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Mon Sep 25 12:56:52 2017 +0200
add invalidation counter to query cache
commit 77740eb
Merge: 31213ef 4d20d50
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Tue Sep 12 09:33:49 2017 +0200
Merge branch 'devel' of https://github.com/arangodb/arangodb into feature/planning-query-result-cache
* 'devel' of https://github.com/arangodb/arangodb:
fix cleanup
Remove override of testmatrix (build only linux)
Fix Foxx queue test (#3219)
commit 31213ef
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Mon Sep 11 22:08:19 2017 +0200
add custom type for ranges and stringification for more nodes
as well as emplaceValue() to AqlItemBlock
commit e9230ca
Merge: c9d9c0e cf66414
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Mon Sep 11 11:35:38 2017 +0200
Merge branch 'devel' of https://github.com/arangodb/arangodb into feature/planning-query-result-cache
* 'devel' of https://github.com/arangodb/arangodb:
fix compilation in non-maintainer-mode
Feature/jenkins pipeline (#3218)
increase cache lifetime for cluster selectivity estimates
fixed a bug, where when servers failed, when also agency leadership c… (#3189)
added new test suite authentication_server
No access collections Improvements (#3190)
removing unnecessary rate limiting (#3194)
fix duplicate mutex (#3215)
updated CHANGELOG
Feature/jenkins pipeline (#3210)
Aardvark: Disable vertical line in query explain editor
commit c9d9c0e
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Fri Sep 8 17:01:03 2017 +0200
query result cache: recreate AqlItemBlocks from cache before sending
commit 8299618
Merge: aa35e84 98e6484
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Wed Sep 6 15:35:58 2017 +0200
Merge branch 'devel' of https://github.com/arangodb/arangodb into feature/planning-query-result-cache
* 'devel' of https://github.com/arangodb/arangodb:
Fix bug in RocksDB incremental collection sync for empty colls. (#3207)
commit aa35e84
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Wed Sep 6 15:34:47 2017 +0200
query result cache: fix ast stringification
commit 2bf05bd
Merge: 94f17bc eacad99
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Tue Sep 5 08:44:11 2017 +0200
Merge branch 'devel' of https://github.com/arangodb/arangodb into feature/planning-query-result-cache
* 'devel' of https://github.com/arangodb/arangodb:
Bug fix/fixes 0409 (#3199)
give usefull errors in case of rocksdb init aborting with 'IOError' w… (#3178)
Handle non-existing user config in RestUserHandler (#3200)
Bug fix/truncate geo (#3173)
fix deadlocks in cluster traversals (#3198)
execute DOCUMENT function via CXX on coordinator in cluster mode (#3196)
Bug fix/fixes 0109 (#3191)
commit 94f17bc
Merge: 070b0aa 76dbc2e
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Mon Sep 4 17:03:20 2017 +0200
Merge branch 'devel' of https://github.com/arangodb/arangodb into feature/planning-query-result-cache
* 'devel' of https://github.com/arangodb/arangodb:
Add tick to batch result. (#3195)
added option `--server.check-max-memory-mappings` (#3185)
removed useless explain
fix windows ifdefs
fixes for MSVC
potential fix for MSVC
fix clang warnings
Bug fix/enterprise build quick fix (#3183)
fix broken enterprise build (#3181)
fix systemd issues when reinstalling a package
commit 070b0aa
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Mon Sep 4 17:02:36 2017 +0200
cluster query cache: first items are returned from the cache
commit 93b4d87
Merge: 5f46fa1 dfb5630
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Fri Sep 1 09:38:34 2017 +0200
Merge branch 'devel' of https://github.com/arangodb/arangodb into feature/planning-query-result-cache
* 'devel' of https://github.com/arangodb/arangodb:
PUBLIC enterprise definitions
Feature/unique vpack index lookup performance improvements with rocksdbkey optimizations (#3123)
correct tempdir under windows
Making foxx-queues test deterministic (#3172)
Optimizations for Caches and Graph Traversals (#3169)
Merge with latest changes in improve-jenkins
Fix compiler warnings and needlessly failing catch tests. (#3171)
Bug fix/unordered map changes order in catch tests (#3175)
be more ignorant about existing or missing directories on startup / cleanup.
fix upgrade exit codes
fix postinst script of debian package
commit 5f46fa1
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Fri Sep 1 09:37:53 2017 +0200
query result cache: implement code in RestHandler
commit 8722da5
Merge: fa41b11 86db523
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Thu Aug 31 07:22:18 2017 +0200
Merge branch 'devel' of https://github.com/arangodb/arangodb into feature/planning-query-result-cache
* 'devel' of https://github.com/arangodb/arangodb:
fix compile warning in non-maintainer mode
windows implementation was missing
Feature/cluster inventory version (#3152)
fixed some MSVC warnings
rename scripts
change to devel
commit fa41b11
Merge: 7ba5dc8 e7a606a
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Wed Aug 30 12:10:17 2017 +0200
Merge branch 'devel' of https://github.com/arangodb/arangodb into feature/planning-query-result-cache
* 'devel' of https://github.com/arangodb/arangodb:
updated CHANGELOG
commit 7ba5dc8
Merge: 85eddc3 94e9744
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Wed Aug 30 12:04:13 2017 +0200
Merge branch 'devel' of https://github.com/arangodb/arangodb into feature/planning-query-result-cache
* 'devel' of https://github.com/arangodb/arangodb:
order of free and free2 changed with use of unordered_multimap vs multimap (#3168)
jslint (#3167)
Cleanup after each testrun (#3109)
Feature/planning 499 different error codes for version check (#3118)
Remove attribute option for arangoimp (#3141)
Bug fix/agency mt fixes (#3158)
When the user entered non-matching passwords, we need to go back two steps so he can re-enter the first password too. (#3155)
Changed some tasks to post through Scheduler instead of directly. (#3159)
Bug fix/scheduling et al (#3161)
commit 85eddc3
Merge: f5c99f7 ec2191c
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Wed Aug 30 08:35:52 2017 +0200
Merge branch 'devel' of https://github.com/arangodb/arangodb into feature/planning-query-result-cache
* 'devel' of https://github.com/arangodb/arangodb:
Proper defaults
Failed regex
rename
no more real
Publish a basic but hopefully working pipeline
dont sleep at start (#3164)
Bug fix/fixes 2808 (#3156)
Improvements to CachedValue internals and handling. (#3126)
Fixing error reporting in arangoimp (#3153)
Don't use global static variables as collection caches - this may cau… (#3150)
Added a more descriptiove documentation about ArangoRestore when using authentication and UserManagement. As required by: #3023 (#3148)
Bug fix/issue 3106 orphans in general graph (#3147)
added resilience to pipelince for cluster tests (#3140)
fixed a bug in create collection in cluster, where transaction result was not checked for success before access (#3137)
Fix HTTP Foxx API Json parsing (#3129)
Report proper error for arangoimp create collection failure. (#3127)
Bug fix/foxx queue auth (devel) (#3122)
fixed wrong ui cluster health information (#3151)
commit f5c99f7
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Wed Aug 30 08:16:42 2017 +0200
query result cache: add cacheUse() function to AqlQuery
commit ad103f1
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Tue Aug 29 14:47:00 2017 +0200
query result cache: prepare caching in resthandler
commit 10d500a
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Tue Aug 29 10:16:13 2017 +0200
increment version number in documentation (manpages)
commit f22f838
Merge: b3d2316 7d72f13
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Mon Aug 28 10:44:19 2017 +0200
Merge branch 'devel' of https://github.com/arangodb/arangodb into feature/planning-query-result-cache
* 'devel' of https://github.com/arangodb/arangodb:
handle the NODE_MODULES_DIR via a global variable.
cleanup our workplace before we do a distbuild
remove obsolete, dysfunctional endpoints (#3135)
No access collections (#3088)
Adding missing changelog / breaking upgrades entries (#3128)
added missing CHANGELOG entry (#3124)
Bug fix/scheduler delete (#3077)
remove directory first, so we don't copy it into a sub directory
use indices on our foxx queues queries; Migrate queries away from aqb… (#3101)
when running the client tests on an already running server we have to specify the server root directory. (#3102)
Fix foxx queue test (#3119)
Bug fix/issues 2308 (#3117)
a few simplifications and extensions (#3115)
fight msvc warnings (#3112)
Feature/unique vpack index lookup performance improvements (#3087)
commit b3d2316
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Fri Aug 25 15:43:27 2017 +0200
Add fakequery string to creation of queries on DBServers
commit fa5564e
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Fri Aug 25 11:48:43 2017 +0200
Add fakequery string to query when receiving via RestAqlHandler
commit 667bc35
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Fri Aug 25 11:47:59 2017 +0200
send query string to DBServers
commit 279e9bd
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Fri Aug 25 10:21:56 2017 +0200
get fake stringification working for basic cases
commit 08b80bf
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Thu Aug 24 16:57:48 2017 +0200
query result cache: add fake stringify for some nodes
commit 4d2ba5e
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Thu Aug 24 12:04:21 2017 +0200
query result cache: prepare hash value creation
commit da40a02
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Thu Aug 24 10:07:39 2017 +0200
result cache: update functiosn in v8-vocbase
commit f502af8
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Thu Aug 24 09:46:33 2017 +0200
result cache: move code (share with v8) and implement clear()
commit c529c24
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Thu Aug 24 07:50:34 2017 +0200
add code for properties
ObiWahn
added a commit
that referenced
this pull request
Dec 22, 2017
commit 6e7a1d1a4d8aa32f43f1683cdcfda7e91d1087bd
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Thu Sep 28 10:12:14 2017 +0200
append shardid to query string
commit a8feac0
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Thu Sep 28 09:29:10 2017 +0200
add missing items at shutdown and fix skipsome
commit 31ddbc1
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Mon Sep 25 14:01:45 2017 +0200
make use of cachecheck in RestAqlHandler, change logging and fix other
commit 1260768
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Mon Sep 25 12:56:52 2017 +0200
add invalidation counter to query cache
commit 77740eb
Merge: 31213ef 4d20d50
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Tue Sep 12 09:33:49 2017 +0200
Merge branch 'devel' of https://github.com/arangodb/arangodb into feature/planning-query-result-cache
* 'devel' of https://github.com/arangodb/arangodb:
fix cleanup
Remove override of testmatrix (build only linux)
Fix Foxx queue test (#3219)
commit 31213ef
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Mon Sep 11 22:08:19 2017 +0200
add custom type for ranges and stringification for more nodes
as well as emplaceValue() to AqlItemBlock
commit e9230ca
Merge: c9d9c0e cf66414
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Mon Sep 11 11:35:38 2017 +0200
Merge branch 'devel' of https://github.com/arangodb/arangodb into feature/planning-query-result-cache
* 'devel' of https://github.com/arangodb/arangodb:
fix compilation in non-maintainer-mode
Feature/jenkins pipeline (#3218)
increase cache lifetime for cluster selectivity estimates
fixed a bug, where when servers failed, when also agency leadership c… (#3189)
added new test suite authentication_server
No access collections Improvements (#3190)
removing unnecessary rate limiting (#3194)
fix duplicate mutex (#3215)
updated CHANGELOG
Feature/jenkins pipeline (#3210)
Aardvark: Disable vertical line in query explain editor
commit c9d9c0e
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Fri Sep 8 17:01:03 2017 +0200
query result cache: recreate AqlItemBlocks from cache before sending
commit 8299618
Merge: aa35e84 98e6484
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Wed Sep 6 15:35:58 2017 +0200
Merge branch 'devel' of https://github.com/arangodb/arangodb into feature/planning-query-result-cache
* 'devel' of https://github.com/arangodb/arangodb:
Fix bug in RocksDB incremental collection sync for empty colls. (#3207)
commit aa35e84
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Wed Sep 6 15:34:47 2017 +0200
query result cache: fix ast stringification
commit 2bf05bd
Merge: 94f17bc eacad99
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Tue Sep 5 08:44:11 2017 +0200
Merge branch 'devel' of https://github.com/arangodb/arangodb into feature/planning-query-result-cache
* 'devel' of https://github.com/arangodb/arangodb:
Bug fix/fixes 0409 (#3199)
give usefull errors in case of rocksdb init aborting with 'IOError' w… (#3178)
Handle non-existing user config in RestUserHandler (#3200)
Bug fix/truncate geo (#3173)
fix deadlocks in cluster traversals (#3198)
execute DOCUMENT function via CXX on coordinator in cluster mode (#3196)
Bug fix/fixes 0109 (#3191)
commit 94f17bc
Merge: 070b0aa 76dbc2e
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Mon Sep 4 17:03:20 2017 +0200
Merge branch 'devel' of https://github.com/arangodb/arangodb into feature/planning-query-result-cache
* 'devel' of https://github.com/arangodb/arangodb:
Add tick to batch result. (#3195)
added option `--server.check-max-memory-mappings` (#3185)
removed useless explain
fix windows ifdefs
fixes for MSVC
potential fix for MSVC
fix clang warnings
Bug fix/enterprise build quick fix (#3183)
fix broken enterprise build (#3181)
fix systemd issues when reinstalling a package
commit 070b0aa
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Mon Sep 4 17:02:36 2017 +0200
cluster query cache: first items are returned from the cache
commit 93b4d87
Merge: 5f46fa1 dfb5630
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Fri Sep 1 09:38:34 2017 +0200
Merge branch 'devel' of https://github.com/arangodb/arangodb into feature/planning-query-result-cache
* 'devel' of https://github.com/arangodb/arangodb:
PUBLIC enterprise definitions
Feature/unique vpack index lookup performance improvements with rocksdbkey optimizations (#3123)
correct tempdir under windows
Making foxx-queues test deterministic (#3172)
Optimizations for Caches and Graph Traversals (#3169)
Merge with latest changes in improve-jenkins
Fix compiler warnings and needlessly failing catch tests. (#3171)
Bug fix/unordered map changes order in catch tests (#3175)
be more ignorant about existing or missing directories on startup / cleanup.
fix upgrade exit codes
fix postinst script of debian package
commit 5f46fa1
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Fri Sep 1 09:37:53 2017 +0200
query result cache: implement code in RestHandler
commit 8722da5
Merge: fa41b11 86db523
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Thu Aug 31 07:22:18 2017 +0200
Merge branch 'devel' of https://github.com/arangodb/arangodb into feature/planning-query-result-cache
* 'devel' of https://github.com/arangodb/arangodb:
fix compile warning in non-maintainer mode
windows implementation was missing
Feature/cluster inventory version (#3152)
fixed some MSVC warnings
rename scripts
change to devel
commit fa41b11
Merge: 7ba5dc8 e7a606a
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Wed Aug 30 12:10:17 2017 +0200
Merge branch 'devel' of https://github.com/arangodb/arangodb into feature/planning-query-result-cache
* 'devel' of https://github.com/arangodb/arangodb:
updated CHANGELOG
commit 7ba5dc8
Merge: 85eddc3 94e9744
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Wed Aug 30 12:04:13 2017 +0200
Merge branch 'devel' of https://github.com/arangodb/arangodb into feature/planning-query-result-cache
* 'devel' of https://github.com/arangodb/arangodb:
order of free and free2 changed with use of unordered_multimap vs multimap (#3168)
jslint (#3167)
Cleanup after each testrun (#3109)
Feature/planning 499 different error codes for version check (#3118)
Remove attribute option for arangoimp (#3141)
Bug fix/agency mt fixes (#3158)
When the user entered non-matching passwords, we need to go back two steps so he can re-enter the first password too. (#3155)
Changed some tasks to post through Scheduler instead of directly. (#3159)
Bug fix/scheduling et al (#3161)
commit 85eddc3
Merge: f5c99f7 ec2191c
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Wed Aug 30 08:35:52 2017 +0200
Merge branch 'devel' of https://github.com/arangodb/arangodb into feature/planning-query-result-cache
* 'devel' of https://github.com/arangodb/arangodb:
Proper defaults
Failed regex
rename
no more real
Publish a basic but hopefully working pipeline
dont sleep at start (#3164)
Bug fix/fixes 2808 (#3156)
Improvements to CachedValue internals and handling. (#3126)
Fixing error reporting in arangoimp (#3153)
Don't use global static variables as collection caches - this may cau… (#3150)
Added a more descriptiove documentation about ArangoRestore when using authentication and UserManagement. As required by: #3023 (#3148)
Bug fix/issue 3106 orphans in general graph (#3147)
added resilience to pipelince for cluster tests (#3140)
fixed a bug in create collection in cluster, where transaction result was not checked for success before access (#3137)
Fix HTTP Foxx API Json parsing (#3129)
Report proper error for arangoimp create collection failure. (#3127)
Bug fix/foxx queue auth (devel) (#3122)
fixed wrong ui cluster health information (#3151)
commit f5c99f7
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Wed Aug 30 08:16:42 2017 +0200
query result cache: add cacheUse() function to AqlQuery
commit ad103f1
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Tue Aug 29 14:47:00 2017 +0200
query result cache: prepare caching in resthandler
commit 10d500a
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Tue Aug 29 10:16:13 2017 +0200
increment version number in documentation (manpages)
commit f22f838
Merge: b3d2316 7d72f13
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Mon Aug 28 10:44:19 2017 +0200
Merge branch 'devel' of https://github.com/arangodb/arangodb into feature/planning-query-result-cache
* 'devel' of https://github.com/arangodb/arangodb:
handle the NODE_MODULES_DIR via a global variable.
cleanup our workplace before we do a distbuild
remove obsolete, dysfunctional endpoints (#3135)
No access collections (#3088)
Adding missing changelog / breaking upgrades entries (#3128)
added missing CHANGELOG entry (#3124)
Bug fix/scheduler delete (#3077)
remove directory first, so we don't copy it into a sub directory
use indices on our foxx queues queries; Migrate queries away from aqb… (#3101)
when running the client tests on an already running server we have to specify the server root directory. (#3102)
Fix foxx queue test (#3119)
Bug fix/issues 2308 (#3117)
a few simplifications and extensions (#3115)
fight msvc warnings (#3112)
Feature/unique vpack index lookup performance improvements (#3087)
commit b3d2316
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Fri Aug 25 15:43:27 2017 +0200
Add fakequery string to creation of queries on DBServers
commit fa5564e
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Fri Aug 25 11:48:43 2017 +0200
Add fakequery string to query when receiving via RestAqlHandler
commit 667bc35
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Fri Aug 25 11:47:59 2017 +0200
send query string to DBServers
commit 279e9bd
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Fri Aug 25 10:21:56 2017 +0200
get fake stringification working for basic cases
commit 08b80bf
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Thu Aug 24 16:57:48 2017 +0200
query result cache: add fake stringify for some nodes
commit 4d2ba5e
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Thu Aug 24 12:04:21 2017 +0200
query result cache: prepare hash value creation
commit da40a02
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Thu Aug 24 10:07:39 2017 +0200
result cache: update functiosn in v8-vocbase
commit f502af8
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Thu Aug 24 09:46:33 2017 +0200
result cache: move code (share with v8) and implement clear()
commit c529c24
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Thu Aug 24 07:50:34 2017 +0200
add code for properties
ObiWahn
added a commit
that referenced
this pull request
Jan 25, 2018
commit 6e7a1d1a4d8aa32f43f1683cdcfda7e91d1087bd
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Thu Sep 28 10:12:14 2017 +0200
append shardid to query string
commit a8feac0
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Thu Sep 28 09:29:10 2017 +0200
add missing items at shutdown and fix skipsome
commit 31ddbc1
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Mon Sep 25 14:01:45 2017 +0200
make use of cachecheck in RestAqlHandler, change logging and fix other
commit 1260768
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Mon Sep 25 12:56:52 2017 +0200
add invalidation counter to query cache
commit 77740eb
Merge: 31213ef 4d20d50
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Tue Sep 12 09:33:49 2017 +0200
Merge branch 'devel' of https://github.com/arangodb/arangodb into feature/planning-query-result-cache
* 'devel' of https://github.com/arangodb/arangodb:
fix cleanup
Remove override of testmatrix (build only linux)
Fix Foxx queue test (#3219)
commit 31213ef
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Mon Sep 11 22:08:19 2017 +0200
add custom type for ranges and stringification for more nodes
as well as emplaceValue() to AqlItemBlock
commit e9230ca
Merge: c9d9c0e cf66414
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Mon Sep 11 11:35:38 2017 +0200
Merge branch 'devel' of https://github.com/arangodb/arangodb into feature/planning-query-result-cache
* 'devel' of https://github.com/arangodb/arangodb:
fix compilation in non-maintainer-mode
Feature/jenkins pipeline (#3218)
increase cache lifetime for cluster selectivity estimates
fixed a bug, where when servers failed, when also agency leadership c… (#3189)
added new test suite authentication_server
No access collections Improvements (#3190)
removing unnecessary rate limiting (#3194)
fix duplicate mutex (#3215)
updated CHANGELOG
Feature/jenkins pipeline (#3210)
Aardvark: Disable vertical line in query explain editor
commit c9d9c0e
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Fri Sep 8 17:01:03 2017 +0200
query result cache: recreate AqlItemBlocks from cache before sending
commit 8299618
Merge: aa35e84 98e6484
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Wed Sep 6 15:35:58 2017 +0200
Merge branch 'devel' of https://github.com/arangodb/arangodb into feature/planning-query-result-cache
* 'devel' of https://github.com/arangodb/arangodb:
Fix bug in RocksDB incremental collection sync for empty colls. (#3207)
commit aa35e84
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Wed Sep 6 15:34:47 2017 +0200
query result cache: fix ast stringification
commit 2bf05bd
Merge: 94f17bc eacad99
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Tue Sep 5 08:44:11 2017 +0200
Merge branch 'devel' of https://github.com/arangodb/arangodb into feature/planning-query-result-cache
* 'devel' of https://github.com/arangodb/arangodb:
Bug fix/fixes 0409 (#3199)
give usefull errors in case of rocksdb init aborting with 'IOError' w… (#3178)
Handle non-existing user config in RestUserHandler (#3200)
Bug fix/truncate geo (#3173)
fix deadlocks in cluster traversals (#3198)
execute DOCUMENT function via CXX on coordinator in cluster mode (#3196)
Bug fix/fixes 0109 (#3191)
commit 94f17bc
Merge: 070b0aa 76dbc2e
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Mon Sep 4 17:03:20 2017 +0200
Merge branch 'devel' of https://github.com/arangodb/arangodb into feature/planning-query-result-cache
* 'devel' of https://github.com/arangodb/arangodb:
Add tick to batch result. (#3195)
added option `--server.check-max-memory-mappings` (#3185)
removed useless explain
fix windows ifdefs
fixes for MSVC
potential fix for MSVC
fix clang warnings
Bug fix/enterprise build quick fix (#3183)
fix broken enterprise build (#3181)
fix systemd issues when reinstalling a package
commit 070b0aa
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Mon Sep 4 17:02:36 2017 +0200
cluster query cache: first items are returned from the cache
commit 93b4d87
Merge: 5f46fa1 dfb5630
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Fri Sep 1 09:38:34 2017 +0200
Merge branch 'devel' of https://github.com/arangodb/arangodb into feature/planning-query-result-cache
* 'devel' of https://github.com/arangodb/arangodb:
PUBLIC enterprise definitions
Feature/unique vpack index lookup performance improvements with rocksdbkey optimizations (#3123)
correct tempdir under windows
Making foxx-queues test deterministic (#3172)
Optimizations for Caches and Graph Traversals (#3169)
Merge with latest changes in improve-jenkins
Fix compiler warnings and needlessly failing catch tests. (#3171)
Bug fix/unordered map changes order in catch tests (#3175)
be more ignorant about existing or missing directories on startup / cleanup.
fix upgrade exit codes
fix postinst script of debian package
commit 5f46fa1
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Fri Sep 1 09:37:53 2017 +0200
query result cache: implement code in RestHandler
commit 8722da5
Merge: fa41b11 86db523
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Thu Aug 31 07:22:18 2017 +0200
Merge branch 'devel' of https://github.com/arangodb/arangodb into feature/planning-query-result-cache
* 'devel' of https://github.com/arangodb/arangodb:
fix compile warning in non-maintainer mode
windows implementation was missing
Feature/cluster inventory version (#3152)
fixed some MSVC warnings
rename scripts
change to devel
commit fa41b11
Merge: 7ba5dc8 e7a606a
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Wed Aug 30 12:10:17 2017 +0200
Merge branch 'devel' of https://github.com/arangodb/arangodb into feature/planning-query-result-cache
* 'devel' of https://github.com/arangodb/arangodb:
updated CHANGELOG
commit 7ba5dc8
Merge: 85eddc3 94e9744
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Wed Aug 30 12:04:13 2017 +0200
Merge branch 'devel' of https://github.com/arangodb/arangodb into feature/planning-query-result-cache
* 'devel' of https://github.com/arangodb/arangodb:
order of free and free2 changed with use of unordered_multimap vs multimap (#3168)
jslint (#3167)
Cleanup after each testrun (#3109)
Feature/planning 499 different error codes for version check (#3118)
Remove attribute option for arangoimp (#3141)
Bug fix/agency mt fixes (#3158)
When the user entered non-matching passwords, we need to go back two steps so he can re-enter the first password too. (#3155)
Changed some tasks to post through Scheduler instead of directly. (#3159)
Bug fix/scheduling et al (#3161)
commit 85eddc3
Merge: f5c99f7 ec2191c
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Wed Aug 30 08:35:52 2017 +0200
Merge branch 'devel' of https://github.com/arangodb/arangodb into feature/planning-query-result-cache
* 'devel' of https://github.com/arangodb/arangodb:
Proper defaults
Failed regex
rename
no more real
Publish a basic but hopefully working pipeline
dont sleep at start (#3164)
Bug fix/fixes 2808 (#3156)
Improvements to CachedValue internals and handling. (#3126)
Fixing error reporting in arangoimp (#3153)
Don't use global static variables as collection caches - this may cau… (#3150)
Added a more descriptiove documentation about ArangoRestore when using authentication and UserManagement. As required by: #3023 (#3148)
Bug fix/issue 3106 orphans in general graph (#3147)
added resilience to pipelince for cluster tests (#3140)
fixed a bug in create collection in cluster, where transaction result was not checked for success before access (#3137)
Fix HTTP Foxx API Json parsing (#3129)
Report proper error for arangoimp create collection failure. (#3127)
Bug fix/foxx queue auth (devel) (#3122)
fixed wrong ui cluster health information (#3151)
commit f5c99f7
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Wed Aug 30 08:16:42 2017 +0200
query result cache: add cacheUse() function to AqlQuery
commit ad103f1
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Tue Aug 29 14:47:00 2017 +0200
query result cache: prepare caching in resthandler
commit 10d500a
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Tue Aug 29 10:16:13 2017 +0200
increment version number in documentation (manpages)
commit f22f838
Merge: b3d2316 7d72f13
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Mon Aug 28 10:44:19 2017 +0200
Merge branch 'devel' of https://github.com/arangodb/arangodb into feature/planning-query-result-cache
* 'devel' of https://github.com/arangodb/arangodb:
handle the NODE_MODULES_DIR via a global variable.
cleanup our workplace before we do a distbuild
remove obsolete, dysfunctional endpoints (#3135)
No access collections (#3088)
Adding missing changelog / breaking upgrades entries (#3128)
added missing CHANGELOG entry (#3124)
Bug fix/scheduler delete (#3077)
remove directory first, so we don't copy it into a sub directory
use indices on our foxx queues queries; Migrate queries away from aqb… (#3101)
when running the client tests on an already running server we have to specify the server root directory. (#3102)
Fix foxx queue test (#3119)
Bug fix/issues 2308 (#3117)
a few simplifications and extensions (#3115)
fight msvc warnings (#3112)
Feature/unique vpack index lookup performance improvements (#3087)
commit b3d2316
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Fri Aug 25 15:43:27 2017 +0200
Add fakequery string to creation of queries on DBServers
commit fa5564e
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Fri Aug 25 11:48:43 2017 +0200
Add fakequery string to query when receiving via RestAqlHandler
commit 667bc35
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Fri Aug 25 11:47:59 2017 +0200
send query string to DBServers
commit 279e9bd
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Fri Aug 25 10:21:56 2017 +0200
get fake stringification working for basic cases
commit 08b80bf
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Thu Aug 24 16:57:48 2017 +0200
query result cache: add fake stringify for some nodes
commit 4d2ba5e
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Thu Aug 24 12:04:21 2017 +0200
query result cache: prepare hash value creation
commit da40a02
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Thu Aug 24 10:07:39 2017 +0200
result cache: update functiosn in v8-vocbase
commit f502af8
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Thu Aug 24 09:46:33 2017 +0200
result cache: move code (share with v8) and implement clear()
commit c529c24
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Thu Aug 24 07:50:34 2017 +0200
add code for properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3065.