This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e of the versions plugin)
Netlify build image updated, new Docker image verified with https://jenkins.arangodb.biz/view/Documentation/job/arangodb-ANY-examples/2516/ |
…eps-2022-10-11
…k.file Jekyll >= 4.3.0 uses Rouge 4.0+ which requires Ruby >= 2.7.0, making it incompatible with our Ruby 2.6.x setup
Fixed problem with Docker builds failing because Jekyll 4.3.x was released and uses a Rouge version incompatible with our Ruby 2.6:
https://jenkins01.arangodb.biz/view/Documentation/job/arangodb-ANY-examples/2562/ |
dandimeo
approved these changes
Nov 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything works after last docker file fix, approved.
nerpaula
approved these changes
Nov 9, 2022
Simran-B
force-pushed
the
update-deps-2022-10-11
branch
from
November 9, 2022 13:43
04c2b83
to
bf99e15
Compare
Simran-B
added a commit
that referenced
this pull request
Nov 9, 2022
* Update to Jekyll 4.2.2, bundler 2.3.23, and other deps * Use _site/docs as output folder to make running htmltest easier * Adjustments for new output folder * Change Netlify publish directory * Adjust README for output dir, add jekyll clean and htmltest * Disable generation of unversioned redirects to stable (default feature of the versions plugin) * kube-arangodb: Conditional content about 3.9+ license management * Let Jenkins target _site/docs but place build artifact in the well-known location * Leave Jekyll installation to bundler to install version as per Gemlock.file Jekyll >= 4.3.0 uses Rouge 4.0+ which requires Ruby >= 2.7.0, making it incompatible with our Ruby 2.6.x setup * Update Bundler to v2.3.25, Jekyll deps, htmltest 0.16.0 * Remove 3.9+ content from older versions, fix links * Fix more links Co-authored-by: Paula Mihu <97217318+nerpaula@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also changes the default build folder from _site to _site/docs, which allows us to run htmltest easily (PowerShell example):
docker run --rm -it -v ${PWD}:/docs arangodb/arangodb-docs htmltest
This also makes it unnecessary to copy
_site
tohtmltest/docs
in the Netlify CI, which should slightly improve build times.build.sh (used in Jenkins) is also adjusted for the new output location but places the resulting archive into the old location so that the Jenkins jobs do not need to be changed (which would make them incompatible with older states of the docs repo or require additional scripting).
Also disables the generation of unversioned redirects to stable that we didn't use, unveiling some incorrect internal links.
Updates the build image from Xenial to Focal (via the Netlify UI).
https://answers.netlify.com/t/please-read-end-of-support-for-xenial-build-image-everything-you-need-to-know/68239
#1108 did not address this issue because we don't use the Docker image in Netlify.