Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: change @Id to save _key instead of _id #78

Closed
mvollmary opened this issue Jun 15, 2018 · 5 comments
Closed

Feature: change @Id to save _key instead of _id #78

mvollmary opened this issue Jun 15, 2018 · 5 comments

Comments

@mvollmary
Copy link

Currently a field annotated with @Id is saved as _id in ArangoDB. Since this field is more for internal usage and does not offer any benefit to the user, we should change @Id to represent the document field _key instead, like @Key currently does. This eliminates the need of having two fields (for @Id and @Key) when using user generated keys.

@sigh-man
Copy link

Hi, Will this also be added to the 1.x.x branch? (I haven't upgraded spring data yet)

@mvollmary
Copy link
Author

Hi @sigh-man,

because this is a breaking change we have only planned to provide this with the upcoming major release 3.0.0.

@sigh-man
Copy link

sigh-man commented Aug 1, 2018

OK - Thanks. I assume the arango-spring-data 3 will require spring-data 2 ? - I guess I'll just have to get on with upgrading spring ... (been meaning to anyway)

@mvollmary
Copy link
Author

Yes, arangodb-spring-data 3 will require spring-data 2

@mvollmary
Copy link
Author

Implementation done. Feature will be included in the upcoming 3.0.0 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants