Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code quality #12

Merged
merged 76 commits into from
Nov 7, 2022
Merged

Code quality #12

merged 76 commits into from
Nov 7, 2022

Commits on Oct 20, 2022

  1. Add Basic Code Quality Checks

    @geenen124
    geenen124 committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    639f47e View commit details
    Browse the repository at this point in the history

  2. Address isort & black Issues

    @geenen124
    geenen124 committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    3db38b1 View commit details
    Browse the repository at this point in the history

  3. Update Branch Name

    @geenen124
    geenen124 committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    3e69aed View commit details
    Browse the repository at this point in the history

  4. Remove Extraneous Build Job

    @geenen124
    geenen124 committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    1e9c060 View commit details
    Browse the repository at this point in the history

  5. Add Dev Requirements To Setup

    @geenen124
    geenen124 committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    04aac61 View commit details
    Browse the repository at this point in the history

  6. Fix Setup.py

    @geenen124
    geenen124 committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    e5666fa View commit details
    Browse the repository at this point in the history

  7. Ignore Build Files & Artifacts

    @geenen124
    geenen124 committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    0c0ad96 View commit details
    Browse the repository at this point in the history

  8. Address PyG Dep Installation

    @geenen124
    geenen124 committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    26020f6 View commit details
    Browse the repository at this point in the history

  9. WIP Flake8 Changes

    @geenen124
    geenen124 committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    6ec0974 View commit details
    Browse the repository at this point in the history

  10. Address Remainder Of Flake8 Errors

    @geenen124
    geenen124 committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    2ca4807 View commit details
    Browse the repository at this point in the history

  11. Address isort Issues

    @geenen124
    geenen124 committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    4ee1cd9 View commit details
    Browse the repository at this point in the history

  12. Bump Dev Versions

    @geenen124
    geenen124 committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    61f57d0 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2022

  1. Merge branch 'test-coverage' into code-quality

    @sachinsharma9780
    sachinsharma9780 committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    2365abe View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2022

  1. adding typings

    @sachinsharma9780
    sachinsharma9780 committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    5b30ba2 View commit details
    Browse the repository at this point in the history

  2. Delete .DS_Store

    @sachinsharma9780
    sachinsharma9780 authored Oct 27, 2022
    Configuration menu
    Copy the full SHA
    e8c0258 View commit details
    Browse the repository at this point in the history

  3. adding typings and code refactor

    @sachinsharma9780
    sachinsharma9780 committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    0929546 View commit details
    Browse the repository at this point in the history

  4. :Merge branch 'code-quality' of https://github.com/arangoml/fastgraphml… 

    … into code-quality
    @sachinsharma9780
    sachinsharma9780 committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    5adb33c View commit details
    Browse the repository at this point in the history

  5. Delete .DS_Store

    @sachinsharma9780
    sachinsharma9780 authored Oct 27, 2022
    Configuration menu
    Copy the full SHA
    2722a70 View commit details
    Browse the repository at this point in the history

  6. adding typings and code refactor

    @sachinsharma9780
    sachinsharma9780 committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    306e104 View commit details
    Browse the repository at this point in the history

  7. code refactor

    @sachinsharma9780
    sachinsharma9780 committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    c15e713 View commit details
    Browse the repository at this point in the history

  8. code refactor

    @sachinsharma9780
    sachinsharma9780 committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    c47fd45 View commit details
    Browse the repository at this point in the history

  9. code refactor

    @sachinsharma9780
    sachinsharma9780 committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    69d7d09 View commit details
    Browse the repository at this point in the history

  10. code refactor

    @sachinsharma9780
    sachinsharma9780 committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    fcdf959 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2022

  1. code refactor

    @sachinsharma9780
    sachinsharma9780 committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    1ac5403 View commit details
    Browse the repository at this point in the history

  2. code refactor

    @sachinsharma9780
    sachinsharma9780 committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    fc3cd22 View commit details
    Browse the repository at this point in the history

  3. Delete .DS_Store

    @sachinsharma9780
    sachinsharma9780 authored Oct 31, 2022
    Configuration menu
    Copy the full SHA
    c223947 View commit details
    Browse the repository at this point in the history

  4. workflow updates

    @cw00dw0rd
    cw00dw0rd committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    d9a5d9e View commit details
    Browse the repository at this point in the history

  5. resolves merge conflicts for workflow and typings

    @cw00dw0rd
    cw00dw0rd committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    9427015 View commit details
    Browse the repository at this point in the history

  6. merge and ignore rule update

    @cw00dw0rd
    cw00dw0rd committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    b6ed995 View commit details
    Browse the repository at this point in the history

  7. updates runner

    @cw00dw0rd
    cw00dw0rd committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    63c99be View commit details
    Browse the repository at this point in the history

  8. updates runner

    @cw00dw0rd
    cw00dw0rd committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    8900c39 View commit details
    Browse the repository at this point in the history

  9. updates runner

    @cw00dw0rd
    cw00dw0rd committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    d2bbd50 View commit details
    Browse the repository at this point in the history

  10. updates runner

    @cw00dw0rd
    cw00dw0rd committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    8cdb3fe View commit details
    Browse the repository at this point in the history

  11. updates runner

    @cw00dw0rd
    cw00dw0rd committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    918e9a8 View commit details
    Browse the repository at this point in the history

  12. removes assert to resolve #13 adds exception, updates optional typings

    @cw00dw0rd
    cw00dw0rd committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    d5e9b00 View commit details
    Browse the repository at this point in the history

  13. removes type: ignore

    @cw00dw0rd
    cw00dw0rd committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    e49260d View commit details
    Browse the repository at this point in the history

  14. reduces python versions for workflow testing

    @cw00dw0rd
    cw00dw0rd committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    c2991d0 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2022

  1. Update fastgraphml/graph_embeddings/models/dmgi.py 

    Co-authored-by: Alex Geenen <ageenen@pm.me>
    @sachinsharma9780 @geenen124
    sachinsharma9780 and geenen124 authored Nov 3, 2022
    Configuration menu
    Copy the full SHA
    53eb32d View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2022

  1. code refactor

    @sachinsharma9780
    sachinsharma9780 committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    069a595 View commit details
    Browse the repository at this point in the history

  2. code refactor

    @sachinsharma9780
    sachinsharma9780 committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    20fe6b3 View commit details
    Browse the repository at this point in the history

  3. Update tests/conftest.py 

    Co-authored-by: Alex Geenen <ageenen@pm.me>
    @sachinsharma9780 @geenen124
    sachinsharma9780 and geenen124 authored Nov 4, 2022
    Configuration menu
    Copy the full SHA
    73c1633 View commit details
    Browse the repository at this point in the history

  4. code refactor

    @sachinsharma9780
    sachinsharma9780 committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    bdfa880 View commit details
    Browse the repository at this point in the history

  5. code refactor

    @sachinsharma9780
    sachinsharma9780 committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    eaf5e2b View commit details
    Browse the repository at this point in the history

  6. code refactor

    @sachinsharma9780
    sachinsharma9780 committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    eb8b4e3 View commit details
    Browse the repository at this point in the history

  7. code refactor

    @sachinsharma9780
    sachinsharma9780 committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    f22441e View commit details
    Browse the repository at this point in the history

  8. code refactor

    @sachinsharma9780
    sachinsharma9780 committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    2bcd8cf View commit details
    Browse the repository at this point in the history

  9. added new database fastgraphml for testing

    @sachinsharma9780
    sachinsharma9780 committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    91e3b1f View commit details
    Browse the repository at this point in the history

  10. fixing cuda error

    @sachinsharma9780
    sachinsharma9780 committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    364c496 View commit details
    Browse the repository at this point in the history

  11. adding conda run

    @sachinsharma9780
    sachinsharma9780 committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    ee5a00e View commit details
    Browse the repository at this point in the history

  12. Update build.yml 

    Updates dev install with conda
    @cw00dw0rd
    cw00dw0rd authored Nov 4, 2022
    Configuration menu
    Copy the full SHA
    dca51f4 View commit details
    Browse the repository at this point in the history

  13. Update build.yml 

    adds conda run to all lint steps
    @cw00dw0rd
    cw00dw0rd authored Nov 4, 2022
    Configuration menu
    Copy the full SHA
    4813254 View commit details
    Browse the repository at this point in the history

  14. Merge branch 'code-quality' of https://github.com/arangoml/fastgraphml … 

    …into code-quality
    @sachinsharma9780
    sachinsharma9780 committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    1abdf54 View commit details
    Browse the repository at this point in the history

  15. code refactor

    @sachinsharma9780
    sachinsharma9780 committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    b61ca45 View commit details
    Browse the repository at this point in the history

  16. code refactor

    @sachinsharma9780
    sachinsharma9780 committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    3a7f081 View commit details
    Browse the repository at this point in the history

  17. Update build.yml 

    fixes bandit in conda env
    @cw00dw0rd
    cw00dw0rd authored Nov 4, 2022
    Configuration menu
    Copy the full SHA
    b7e6229 View commit details
    Browse the repository at this point in the history

  18. Update build.yml 

    attempted bandit fix
    @cw00dw0rd
    cw00dw0rd authored Nov 4, 2022
    Configuration menu
    Copy the full SHA
    4734c5c View commit details
    Browse the repository at this point in the history

  19. Update setup.cfg 

    adds bandit options
    @cw00dw0rd
    cw00dw0rd authored Nov 4, 2022
    Configuration menu
    Copy the full SHA
    5a9020d View commit details
    Browse the repository at this point in the history

  20. Update setup.cfg 

    reverts bandit cfg
    @cw00dw0rd
    cw00dw0rd authored Nov 4, 2022
    Configuration menu
    Copy the full SHA
    9bce915 View commit details
    Browse the repository at this point in the history

  21. Update build.yml 

    attempting to fix bandit
    @cw00dw0rd
    cw00dw0rd authored Nov 4, 2022
    Configuration menu
    Copy the full SHA
    0da6502 View commit details
    Browse the repository at this point in the history

  22. Update build.yml 

    bandit fix
    @cw00dw0rd
    cw00dw0rd authored Nov 4, 2022
    Configuration menu
    Copy the full SHA
    08baac6 View commit details
    Browse the repository at this point in the history

  23. Update build.yml

    @cw00dw0rd
    cw00dw0rd authored Nov 4, 2022
    Configuration menu
    Copy the full SHA
    6d008b3 View commit details
    Browse the repository at this point in the history

  24. Update build.yml 

    reverts changes after update gpu env
    @cw00dw0rd
    cw00dw0rd authored Nov 4, 2022
    Configuration menu
    Copy the full SHA
    0bdc32e View commit details
    Browse the repository at this point in the history

  25. adds strict versioning for dependencies

    @cw00dw0rd
    cw00dw0rd committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    cbb499c View commit details
    Browse the repository at this point in the history

  26. formatting fix

    @cw00dw0rd
    cw00dw0rd committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    eae9253 View commit details
    Browse the repository at this point in the history

  27. formatting fix

    @cw00dw0rd
    cw00dw0rd committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    6ce2d9a View commit details
    Browse the repository at this point in the history

  28. re-raises exception

    @cw00dw0rd
    cw00dw0rd committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    0ac0a80 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2022

  1. adds release workflow and updates conda env

    @cw00dw0rd
    cw00dw0rd committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    29250bb View commit details
    Browse the repository at this point in the history

  2. removes dist folder and adds to gitignore

    @cw00dw0rd
    cw00dw0rd committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    621aa2a View commit details
    Browse the repository at this point in the history

  3. updates install instructions

    @cw00dw0rd
    cw00dw0rd committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    38419f0 View commit details
    Browse the repository at this point in the history

  4. updates examples to use datasets package

    @cw00dw0rd
    cw00dw0rd committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    2577c7f View commit details
    Browse the repository at this point in the history

  5. adds arango_datasets package

    @cw00dw0rd
    cw00dw0rd committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    4e02aba View commit details
    Browse the repository at this point in the history

  6. removes exceptions class in favor of base Exceptions

    @cw00dw0rd
    cw00dw0rd committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    daa3fff View commit details
    Browse the repository at this point in the history

  7. removes exceptions class in favor of base Exceptions

    @cw00dw0rd
    cw00dw0rd committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    22b67b4 View commit details
    Browse the repository at this point in the history

  8. adds arango_datasets dependency

    @cw00dw0rd
    cw00dw0rd committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    273625c View commit details
    Browse the repository at this point in the history

  9. adds test for similarity search exception

    @cw00dw0rd
    cw00dw0rd committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    e2bbe31 View commit details
    Browse the repository at this point in the history

  10. fixes test password

    @cw00dw0rd
    cw00dw0rd committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    b2a3dd7 View commit details
    Browse the repository at this point in the history