Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cast error on the "limit" option #24

Closed
Tititrois opened this issue Mar 25, 2019 · 3 comments
Closed

Cast error on the "limit" option #24

Tititrois opened this issue Mar 25, 2019 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@Tititrois
Copy link

Describe the bug
I'm not sure if it's wanted or not, but I will still report it. When submitting the mongoose request, if the limit option is a string (for example "10"), it's returning an error. In my case, I receive the option list from some query params and thus, they are in a String format event for integer.
It's happening only for the limit option (page is working fine with a string).

To Reproduce
Simply submit a mongoose paginate request follow the description above.

Expected behavior
Can the library do the integer cast for the limit option ?

@aravindnc
Copy link
Owner

@Tititrois Thanks for pointing this out.

@aravindnc aravindnc self-assigned this Mar 27, 2019
@aravindnc aravindnc added the bug Something isn't working label Mar 27, 2019
@aravindnc
Copy link
Owner

@Tititrois This has been fixed.

aravindnc added a commit that referenced this issue Apr 24, 2019
@Tititrois
Copy link
Author

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants