Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change rect select #219

Merged
merged 2 commits into from
Dec 5, 2023
Merged

change rect select #219

merged 2 commits into from
Dec 5, 2023

Conversation

sanglevinh
Copy link
Collaborator

Screenshot 2023-12-04 at 16 08 09

@sanglevinh sanglevinh linked an issue Dec 4, 2023 that may be closed by this pull request
Fix drag selector #187
Closed
@sanglevinh sanglevinh marked this pull request as ready for review December 4, 2023 10:46
ReiHashimoto
ReiHashimoto approved these changes Dec 5, 2023
View reviewed changes
Copy link

@ReiHashimoto ReiHashimoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your implementation.

Trying some style, I changed stroke style by myself.

@ReiHashimoto ReiHashimoto merged commit 40ae189 into develop-main Dec 5, 2023
2 checks passed
@ReiHashimoto ReiHashimoto deleted the feature/fix_drag_select branch December 5, 2023 07:15
@ReiHashimoto ReiHashimoto mentioned this pull request Dec 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReiHashimoto ReiHashimoto ReiHashimoto approved these changes

@itutu-tienday itutu-tienday Awaiting requested review from itutu-tienday

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix drag selector
2 participants
@sanglevinh @ReiHashimoto