Underwater fix #18
Open
Underwater fix #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using FiveM natives to switch from checking if player is simply below water level to actually checking if they are diving. This fixes issues related to muffled "underwater" audio when below water level, but not diving (inside interiors, in the metro, etc.). This also allows audio to be muffled when underwater but not below ocean water level (swimming in pools, etc.)
Using FiveM natives to switch from checking if player is simply below water level to actually checking if they are diving. This fixes issues related to muffled "underwater" audio when below water level, but not diving (inside interiors, in the metro, etc.). This also allows audio to be muffled when underwater but not below ocean water level (swimming in pools, etc.)
|
Could you attach a built zip for people to test on? Would help get some feedback on higher population servers. Great work though appreciate it |
|
Here you go: sounity-underwater-fix.zip |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use FiveM natives to switch from checking if player is simply below water level to actually checking if they are diving.
This fixes issues related to muffled "underwater" audio when below water level, but not actually diving (inside interiors, in the metro, etc.). This also allows audio to be muffled when underwater but not below ocean water level (swimming in pools, etc.)