Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print Kokkos version during configuration #609

Merged
merged 3 commits into from
Jan 20, 2022

Conversation

aprokop
Copy link
Contributor

@aprokop aprokop commented Dec 30, 2021

Following the suggestion in this comment.

@aprokop aprokop added the build Build and installation label Dec 30, 2021
CMakeLists.txt Outdated
@@ -1,7 +1,8 @@
cmake_minimum_required(VERSION 3.16)
project(ArborX CXX)

find_package(Kokkos 3.4 REQUIRED)
find_package(Kokkos 3.4 REQUIRED CONFIG)
message(STATUS "Found Kokkos: ${Kokkos_VERSION}")
Copy link
Contributor

@dalg24 dalg24 Dec 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
message(STATUS "Found Kokkos: ${Kokkos_VERSION}")
message(STATUS "Found Kokkos: ${Kokkos_DIR} (version \"${Kokkos_VERSION}\")")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe follow Boost then? Like

-- Found Kokkos: /home/xap/local/opt/kokkos-serial-56468253e/lib/cmake/Kokkos (found suitable version "3.5.99", minimum required is "3.4.00")

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. I was actually trying to figure out where this message is emitted from (the Boost one)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didn't quite apply the suggestion you made above. Is that an oversight?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not see your reply. I'm fine either way. I now realize that each package has its own style. For example, MPI has a different way to print them out compared to Boost. So there is not going to be a single consistent style anyway.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dalg24 Are you OK with the current version?

Co-authored-by: Damien L-G <dalg24+github@gmail.com>
@aprokop
Copy link
Contributor Author

aprokop commented Dec 31, 2021

No idea why CI is reporting failure: all builds passed, and there are no warnings. This is the second time I've seen this in the past few days.

@Rombur
Copy link
Collaborator

Rombur commented Jan 3, 2022

No idea why CI is reporting failure: all builds passed, and there are no warnings. This is the second time I've seen this in the past few days.

Here is the error message, not sure what it means:

Error when executing always post condition:
edu.hm.hafner.analysis.ParsingException: Unable to change directory using: .*Entering directory [`'](?<dir>.*)['`] to match make[2]: Entering directory '/var/jenkins/workspace/ArborX_PR--609/build/examples/callback/CMakeFiles/ArborX_Callback.exe.dir/DependInfo.cmake --color=

@aprokop
Copy link
Contributor Author

aprokop commented Jan 15, 2022

retest this please

@aprokop aprokop merged commit 6794807 into arborx:master Jan 20, 2022
@aprokop aprokop deleted the kokkos_version branch January 20, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build and installation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants