-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print Kokkos version during configuration #609
Conversation
CMakeLists.txt
Outdated
@@ -1,7 +1,8 @@ | |||
cmake_minimum_required(VERSION 3.16) | |||
project(ArborX CXX) | |||
|
|||
find_package(Kokkos 3.4 REQUIRED) | |||
find_package(Kokkos 3.4 REQUIRED CONFIG) | |||
message(STATUS "Found Kokkos: ${Kokkos_VERSION}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
message(STATUS "Found Kokkos: ${Kokkos_VERSION}") | |
message(STATUS "Found Kokkos: ${Kokkos_DIR} (version \"${Kokkos_VERSION}\")") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe follow Boost then? Like
-- Found Kokkos: /home/xap/local/opt/kokkos-serial-56468253e/lib/cmake/Kokkos (found suitable version "3.5.99", minimum required is "3.4.00")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. I was actually trying to figure out where this message is emitted from (the Boost one)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You didn't quite apply the suggestion you made above. Is that an oversight?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not see your reply. I'm fine either way. I now realize that each package has its own style. For example, MPI has a different way to print them out compared to Boost. So there is not going to be a single consistent style anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dalg24 Are you OK with the current version?
Co-authored-by: Damien L-G <dalg24+github@gmail.com>
No idea why CI is reporting failure: all builds passed, and there are no warnings. This is the second time I've seen this in the past few days. |
Here is the error message, not sure what it means:
|
retest this please |
Following the suggestion in this comment.