Fix/issue#998 #1008
Merged
Fix/issue#998 #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… effect that updates lang value in local storage and change language
…ersisted as general
|
@utin-francis-peter is attempting to deploy a commit to the Arc53 Team on Vercel. A member of the Team first needs to authorize it. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1008 +/- ##
==========================================
- Coverage 21.77% 21.69% -0.08%
==========================================
Files 80 80
Lines 3610 3632 +22
==========================================
+ Hits 786 788 +2
- Misses 2824 2844 +20 ☔ View full report in Codecov by Sentry. |
ManishMadan2882
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Perfect @utin-francis-peter , everything works as expected!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
a fix for issue#998
Why was this change needed? (You can also link to an open issue here)
To do the following:
improve UX by not rendering an already active language in the list of languages to choose from
correctly rendering the "General" component when language option is changed to Mandarin or Japanese
Other information:
closes: 🐛 Bug Report: Language switch to Japanese or Mandarin, blackouts the Settings tab selection #998