Storing API Key and recent source docs locally #115
Conversation
|
Hey Taylor, although the local storage thing works but we see a flash of modal when we open the app subsequent times. |
| } catch (error) { | ||
| console.log(error); | ||
| } | ||
| } |
There was a problem hiding this comment.
Any particular reasons why these local storage functions are async? AFAIK local storage web api are sync in nature. Doesnt seem like any async thing happening here.
There was a problem hiding this comment.
yeah I thuogth they maybe should be synchronous but wasnt sure. will change
|
Right now the localstorage and redux are distinct and we are using them together on APIKeyModal mount. This might be the reason why the flash shows up. There should be a better way to sync localstorage and redux together. I dont have a very concrete solution in my mind right now but looking into middlewares would be helpful. We only should be talking to redux in our component layer, rest all should be handled in other layers. https://stackoverflow.com/questions/35305661/where-to-write-to-localstorage-in-a-redux-app |
No description provided.