Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/max exposure #166

Merged
merged 28 commits into from
Jan 5, 2023
Merged

Feat/max exposure #166

merged 28 commits into from
Jan 5, 2023

Conversation

j-vp
Copy link
Member

@j-vp j-vp commented Jan 3, 2023

Adding a max exposure on deposits & withdrawals

@j-vp j-vp requested a review from Thomas-Smets January 3, 2023 08:17
@j-vp j-vp marked this pull request as ready for review January 3, 2023 08:17
Thomas-Smets
Thomas-Smets requested changes Jan 3, 2023
View reviewed changes
Copy link
Member

@Thomas-Smets Thomas-Smets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add documentation and tests before PRs

src/AssetRegistry/MainRegistry.sol Outdated Show resolved Hide resolved
src/Vault.sol Outdated Show resolved Hide resolved
src/Vault.sol Outdated Show resolved Hide resolved
src/AssetRegistry/MainRegistry.sol Show resolved Hide resolved
src/AssetRegistry/MainRegistry.sol Outdated Show resolved Hide resolved
src/AssetRegistry/MainRegistry.sol Show resolved Hide resolved
src/AssetRegistry/MainRegistry.sol Outdated Show resolved Hide resolved
src/Vault.sol Outdated Show resolved Hide resolved
src/AssetRegistry/AbstractPricingModule.sol Outdated Show resolved Hide resolved
src/AssetRegistry/StandardERC20PricingModule.sol Outdated Show resolved Hide resolved
j-vp and others added 12 commits January 3, 2023 23:05
@j-vp @Thomas-Smets
Update src/AssetRegistry/MainRegistry.sol
0424aad 
Co-authored-by: Thomas-Smets <43761140+Thomas-Smets@users.noreply.github.com>
@j-vp
📝 add natspec
805e6f3
@j-vp @Thomas-Smets
✅ add tests & remove unnecessary whitelist views
2f07f96 
Co-authored-by: Thomas-Smets <Thomas-Smets@users.noreply.github.com>
@j-vp
🎨 forge fmt
b624df9
@j-vp
🎨 forge fmt
370198f
@j-vp @Thomas-Smets
🎨 whitelist refactor + exposure tests
aab68cb 
Co-authored-by: Thomas-Smets <43761140+Thomas-Smets@users.noreply.github.com>
@j-vp
🔀 Merge branch 'dev' into feat/maxExposure
34daaa8
@j-vp
⬆️
f21b598
@j-vp
⬆️ upgrade lending
d555c53
@j-vp @Thomas-Smets
🎨 forge fmt
2127bad 
Co-authored-by: Thomas-Smets <43761140+Thomas-Smets@users.noreply.github.com>
@j-vp
✅ fix test on vault withdrawal
61a4b7a
@Thomas-Smets @j-vp
♻️ Refactor white list management
057d3be 
Co-authored-by: Jasper <j-vp@users.noreply.github.com>
Thomas-Smets
Thomas-Smets reviewed Jan 5, 2023
View reviewed changes
src/Vault.sol Outdated Show resolved Hide resolved
@j-vp @Thomas-Smets
📝 update comment
fb0d90e 
Co-authored-by: Thomas-Smets <43761140+Thomas-Smets@users.noreply.github.com>
@j-vp
Copy link
Member Author

j-vp commented Jan 5, 2023 •
edited
Loading

Will add a test for

MR_BPD: Asset not in mainreg

@j-vp j-vp changed the base branch from dev to main January 5, 2023 13:45
@j-vp j-vp requested a review from Thomas-Smets January 5, 2023 13:45
@j-vp j-vp mentioned this pull request Jan 5, 2023
Open
Thomas-Smets
Thomas-Smets approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@Thomas-Smets Thomas-Smets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gtg

@j-vp j-vp merged commit 6fff97a into main Jan 5, 2023
@j-vp j-vp deleted the feat/maxExposure branch January 5, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thomas-Smets Thomas-Smets Thomas-Smets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j-vp @Thomas-Smets