Skip to content
This repository has been archived by the owner on Jun 11, 2022. It is now read-only.

Reborn support? #77

Closed
twisterghost opened this issue Jun 29, 2015 · 12 comments
Closed

Reborn support? #77

twisterghost opened this issue Jun 29, 2015 · 12 comments
Labels

Comments

@twisterghost
Copy link

Will this package be broken when Reborn goes live? Does Reborn use the same GC as current Dota2? Any knowledge in this scope or is this a big if right now?

@idreamshen
Copy link

same question

@XenBG
Copy link
Contributor

XenBG commented Jul 26, 2015

The same question. I see that when I create lobby in Dota 2 (Source 1), I can't see it from Dota 2 Reborn (Source 2).

@jimmydorry
Copy link
Member

They are two different backends, so not surprising.

@paralin
Copy link
Contributor

paralin commented Sep 6, 2015

It's the same backend @jimmydorry.

That said I'm trying to get it to work in the C# version at http://github.com/paralin/Dota2 but no matter how much I implement it still doesn't seem to recognize it as Source2.

@TJRoger
Copy link
Contributor

TJRoger commented Sep 6, 2015

@paralin They are different. Refer to the resources files, you will see the dota_s2 protobufs backend languages.

@paralin
Copy link
Contributor

paralin commented Sep 6, 2015

@TJRoger They aren't different, trust me on this one. The difference between dota and dota_s2 is where they were dumped from. The dota ones stopped being updated a while back. The nature of protobuf is that they are backwards compatible and since reborn is on the same gc as source 1, its just some newer calls added to the existing system.

My proof for this is that the C# version now works with both reborn and regular...

@paralin
Copy link
Contributor

paralin commented Sep 6, 2015

The only difference is when you specify the source engine version in the hello message.

@TJRoger
Copy link
Contributor

TJRoger commented Sep 7, 2015

@paralin OK, you say it, I didn't look into it. Ah ha

@Crazy-Duck
Copy link
Collaborator

@paralin is it sufficient to just change the engine version in the CMsgClientHello or does the appId in the protobuf header also have be changed to 373300 ?

@paralin
Copy link
Contributor

paralin commented Sep 7, 2015

App ID is the same. Just read the code in this file: https://github.com/paralin/Dota2/blob/master/Dota2/GC/DotaGCHandler.cs

@paralin
Copy link
Contributor

paralin commented Sep 10, 2015

Should work with PR #95

@jimmydorry
Copy link
Member

Which was merged into master 2aaa38b

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

7 participants