New Cleo CLI #203
New Cleo CLI #203
Conversation
| ] | ||
|
|
||
|
|
||
| def load_scooze_command(name: str) -> Callable[[], Command]: |
There was a problem hiding this comment.
What does the empty array [] mean in this type hint?
There was a problem hiding this comment.
I'm reading that as "the Callable it returns takes no arguments", but would be good to confirm
There was a problem hiding this comment.
Yep it should always be Callable[[<args type list>], <return type>]
| name = "delete" | ||
| description = "Delete collections from the database." | ||
|
|
||
| options = [ |
There was a problem hiding this comment.
Should probably use arguments instead of options so that the load and delete commands are consistent. Thoughts?
There was a problem hiding this comment.
Agreed on preferring consistency; would that change impact anything else in here?
There was a problem hiding this comment.
Think I just autopiloted this. I'll fix it
| ] | ||
|
|
||
|
|
||
| def load_scooze_command(name: str) -> Callable[[], Command]: |
There was a problem hiding this comment.
I'm reading that as "the Callable it returns takes no arguments", but would be good to confirm
| name = "delete" | ||
| description = "Delete collections from the database." | ||
|
|
||
| options = [ |
There was a problem hiding this comment.
Agreed on preferring consistency; would that change impact anything else in here?
|
|
||
|
|
||
| def delete_collection(coll: DbCollection): | ||
| clean = input(f"Delete existing {coll}? [y/n] ") in "yY" |
There was a problem hiding this comment.
nit at my past self that it'd be convenient to fix here: can this N be capital to indicate it's the default? (and similar for the other files)
|
|
||
| def handle(self): | ||
| # TODO(#201) - Add local MongoDB built-in support | ||
| print("Usage: `scooze setup docker` or `scooze setup local`") |
There was a problem hiding this comment.
Fine to leave this until the later ticket, but this print should indicate local isn't yet supported in CLI.
There was a problem hiding this comment.
Easy enough to add that here since it'd be moot when #201 gets worked on.
|
|
||
| def handle(self): | ||
| # TODO(#201) - Add local MongoDB built-in support | ||
| print("Usage: `scooze teardown docker` or `scooze teardown local`") |
There was a problem hiding this comment.
Fine to leave this until the later ticket, but this print should indicate local isn't yet supported in CLI.
| name = "delete" | ||
| description = "Delete collections from the database." | ||
|
|
||
| arguments = [ |
There was a problem hiding this comment.
@fjork3 @iambroadband as this is currently written now it'll accept an arbitrary list of string args and will act accordingly if it see any of all, cards, or decks. Any other things passed in will be ignored. Do we want to print a message that other stuff passed in was ignored? It'll already say it needs valid input if none of what we expect is passed, but extra stuff isn't handled yet.
There was a problem hiding this comment.
I think it would make sense to print the ignored options too.
|
I changed all the |
| def handle(self): | ||
| # TODO(#201) - Add local MongoDB built-in support | ||
| self.line( | ||
| "Usage: <fg=cyan>scooze setup docker</> or <fg=cyan>scooze setup local</>. Local support coming soon." |
There was a problem hiding this comment.
Message indicating that this isn't implemented. Same as teardown local.
|
|
||
| def handle(self): | ||
| # TODO(#201) - Add local MongoDB built-in support | ||
| self.line( |
There was a problem hiding this comment.
Same as local setup. Not implemented
## [1.0.5] - 2023-11-09 ### Added - Added scooze_id to CardModel and Card. Changed the MongoDB _id to scooze_id. ([#193](#193)) - Added AsyncScoozeApi as a way to use API endpoints in an async context (fixes Jupyter compatibility) ([#199](#199)) - Add Docker support for starting MongoDB via the CLI ([#200](#200)) - CLI rework to be more robust ([#203](#203)) - Github Actions to test on push and deploy on tag ([#211](#211)) - Add `cmc` field to top level for reversible cards ([#212](#212)) ### Changed - Changed the database lookup behavior to treat _id and scooze_id as the same. Also support snake case and camel case for property names. ([#205](#205)) - Added `None` as valid return type in normalizers ([#190](#190)) - Use `super().__init__()` for Card subclasses ([#217](#217)) ### Fixed - Fixed the use of mutable default arguments ([#188](#188)) - Fixed improper runner call in API init ([#190](#190)) - Fixed missing `await` call ([#190](#190)) ### Docs - More completely document possible exceptions ([#209])(#209) --------- Co-authored-by: Ben Horkley <ben.horkley@gmail.com> Co-authored-by: Jacob Ginsparg <jacobginsparg@gmail.com> Co-authored-by: Clayton Mentzer <cwolfmentzer@gmail.com>
Redid the CLI much in the same fashion as how Poetry has theirs set up (see here) using Cleo.