Release 1.0.5 -> main #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jacob Ginsparg <jacobginsparg@gmail.com> Co-authored-by: broadband <iambroadband@gmail.com>
Update the behavior of the ScoozeApi in the following ways: - CardApi is now a collection of async function wrappers around database operations related to cards - ScoozeApi now uses the asyncio.Runner ContextManager to run each of the CardApi endpoints This will prevent problems with "Event Loop is Closed" when calling asyncio.run too many times too quickly. Instead we will now rely on asyncio.Runner.run
We messed up during deploy, so I'm tacking this on after the fact. It'll get cleaned up in the next release.
col_type can potentially be confused for columns rather than collections.
semver on 0.x.x version numbers treats minor updates equivalently to a bump to 1.x.x; our requirement of fastapi at least 0.100.1 was not compatible with the current newest version of 0.103.2. This PR changes that bound to allow newest; we may need to revisit again for other packages or when other 0.x dependencies update versions.
Co-authored-by: Jacob Ginsparg <jacobginsparg@gmail.com> Co-authored-by: broadband <iambroadband@gmail.com>
- None as valid return type on normalizers - typo/docstring cleanup - clean unused imports - missing `await` on async call - improper runner call in API init
Turns out Python doesn't create a new instance of a default mutable argument each time you run `__init__` instead it will create the resource once and then reuse it over and over. We found this bug while working on the words_per_card dogfooding. It was causing all the decks we read in from the file to contain every card from all decks. Oops! This should fix it cleanly. I tested this in the average_words project. Works fine. I've also added a test here to make sure it works.
To test: - pip install scooze - install docker desktop and make sure it's running - run `scooze setup docker` to pull and initailize a docker-based mongo instance - populate that DB as normal with `scooze load-cards oracle` Limitations: - Needs docker installed and running - Needs port 27017 to be free on the host machine --------- Co-authored-by: Ben Horkley <ben.horkley@gmail.com> Co-authored-by: Jacob Ginsparg <jacobginsparg@gmail.com> Co-authored-by: broadband <iambroadband@gmail.com> Co-authored-by: Clayton Mentzer
Reworked the CLI to use Cleo, similar to how Poetry has theirs set up.
- Document possible exceptions in docstrings (#208) - grammar/typos - docstring updates - fix type hinting for type[Generic] - unused imports
) Fixes #194 There are a few extra things here that address some problems I found when trying to use `ScoozeApi.get_card_by()` with list arguments. `@cache` requires hashable arguments.
Co-authored-by: broadband <iambroadband@gmail.com>
fjork3
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release 1.0.5