Use super().__init__() for Card subclasses
#217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjork3
changed the title
super().__init__() to fill subclass fieldssuper().__init__() for Card subclasses
JacobGinsparg
approved these changes
Oct 27, 2023
iambroadband
added a commit
that referenced
this pull request
Nov 10, 2023
## [1.0.5] - 2023-11-09 ### Added - Added scooze_id to CardModel and Card. Changed the MongoDB _id to scooze_id. ([#193](#193)) - Added AsyncScoozeApi as a way to use API endpoints in an async context (fixes Jupyter compatibility) ([#199](#199)) - Add Docker support for starting MongoDB via the CLI ([#200](#200)) - CLI rework to be more robust ([#203](#203)) - Github Actions to test on push and deploy on tag ([#211](#211)) - Add `cmc` field to top level for reversible cards ([#212](#212)) ### Changed - Changed the database lookup behavior to treat _id and scooze_id as the same. Also support snake case and camel case for property names. ([#205](#205)) - Added `None` as valid return type in normalizers ([#190](#190)) - Use `super().__init__()` for Card subclasses ([#217](#217)) ### Fixed - Fixed the use of mutable default arguments ([#188](#188)) - Fixed improper runner call in API init ([#190](#190)) - Fixed missing `await` call ([#190](#190)) ### Docs - More completely document possible exceptions ([#209])(#209) --------- Co-authored-by: Ben Horkley <ben.horkley@gmail.com> Co-authored-by: Jacob Ginsparg <jacobginsparg@gmail.com> Co-authored-by: Clayton Mentzer <cwolfmentzer@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.