Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

world pvp resubmited #347

Closed
wants to merge 5 commits into from
Closed

world pvp resubmited #347

wants to merge 5 commits into from

Conversation

aaron02
Copy link
Contributor

@aaron02 aaron02 commented Feb 7, 2013

resubmit because of bad line endings

@@ -1,17 +1,62 @@
/**
* Summit MMORPG Server Software
* Copyright (c) 2008 Summit Server Team
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason why the old credits were removed ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no reason why i deleted the old credits , i can add them back if u want

@ghost
Copy link

ghost commented Jun 8, 2014

easy rewritable, thanks 👍

@dfighter1985
Copy link
Member

This is going to be the next PR I will examine Soon(tm).
Just by looking at it I can see that I will not be willing and not be able to just merge it, partially because it's from another project.
However I'm sure it will be helpful regardless.

@cressidagp
Copy link

This is going to be the next PR I will examine Soon(tm).
Just by looking at it I can see that I will not be willing and not be able to just merge it, partially because it's from another project.
However I'm sure it will be helpful regardless.

I will be happy if at least Silithus and Eastern Plaguelands gets implemented :)

@dfighter1985
Copy link
Member

This is going to be the next PR I will examine Soon(tm).
Just by looking at it I can see that I will not be willing and not be able to just merge it, partially because it's from another project.
However I'm sure it will be helpful regardless.

I will be happy if at least Silithus and Eastern Plaguelands gets implemented :)

EP doesn't seem to be in the patch, but I can make sure that I check the Silithus part first.

@dfighter1985
Copy link
Member

I started working on this some hours ago.
Silithus is the first as promised, will push it in a day or so, if all goes well.

Funny how I didn't even remember that we had these in the repo, especially since I commited them from the old arcscripts repo more than 13 years ago in:
f3cd20f

Originally they were added from Aspiredev in 2009:
https://sourceforge.net/p/arcscripts/code/630/

dfighter1985 added a commit that referenced this pull request Jan 4, 2024
…equest, which was based on old Summit code. ref #347
@dfighter1985
Copy link
Member

I think I can say that Halaa works now.

https://www.youtube.com/watch?v=veq2vYjss1k

Even if there are issues due to how Arcemu handles cell unloading / reloading.
Will have to deal with that.

@cressidagp
Copy link

Perfect!!! Thanks for the BIG effort! :)

#EpicPRClose

@dfighter1985
Copy link
Member

#EpicPRClose

Not yet, but soon.
If you play enough you will notice that guards and wyvern camps just disappear if you go away for some minutes.

This is because idle map cells are unloaded, and simply spawning objects in a script doesn't make them persist through cell unloads / reloads.
I have to resolve this issue before I can say that it's done.

@cressidagp
Copy link

arcemu/db@c817671

dfighter1985 added a commit that referenced this pull request Feb 6, 2024
dfighter1985 added a commit that referenced this pull request Feb 7, 2024
dfighter1985 added a commit that referenced this pull request Feb 8, 2024
@dfighter1985
Copy link
Member

@aaron02 thanks for submitting this patch!
Although I've only used some identifiers from it, it was still quite useful, and now the functionality is in Arcemu. :)

Closing the PR now.

dfighter1985 added a commit that referenced this pull request Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants