Remove involved nodes in beacon slots as unused #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 2, 2022
ghost
force-pushed
the
06-02-Make_summary_transaction_address_more_consistent
branch
from
8e1877c
to
323083e
Compare
ghost
force-pushed
the
06-02-Remove_involved_nodes_in_beacon_slots_as_unused
branch
from
ac54880
to
f3e45b8
Compare
ghost
marked this pull request as ready for review
ghost
self-assigned this
ghost
changed the base branch from
06-02-Make_summary_transaction_address_more_consistent
to
develop
|
So, are we using p2p_view for the same purpose, or are there any other additions? If yes do add it here for reference. |
The P2P view is used to sample and monitor the availability of given subset of nodes. |
|
Okay Thanks for explanation |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beacon slots contain
involved_nodeswhich was used before, but not anymore.So in order to simplify understanding and encoding, we can remove it.