Write beacon slot to summary chain #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 2, 2022
|
Current dependencies on this PR: Current dependencies for this PR: |
ghost
mentioned this pull request
ghost
force-pushed
the
remove_top_transaction_live_unused
branch
from
5cc9f0d
to
e226f36
Compare
ghost
force-pushed
the
06-02-Write_beacon_slot_to_summary_chain
branch
from
99279c8
to
bee933b
Compare
ghost
mentioned this pull request
ghost
marked this pull request as ready for review
This was referenced Jun 2, 2022
ghost
self-assigned this
ghost
changed the base branch from
develop
to
06-02-Write_transaction_to_specific_genesis_address
ghost
changed the base branch from
06-02-Write_transaction_to_specific_genesis_address
to
develop
imnik11
approved these changes
Jun 5, 2022
| genesis_address = | ||
| Crypto.derive_beacon_chain_address(subset, SummaryTimer.previous_summary(time)) | ||
|
|
||
| TransactionChain.write_transaction_at(beacon_transaction, genesis_address) |
There was a problem hiding this comment.
Ok, This is where we are caching as well as writing to the DB
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the transaction slot to the summary chain by giving the genesis address (from the previous summary date) to append the transaction to.
Type of change
Please delete options that are not relevant.
Checklist: