Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix previous_summary from summary timer #354

Merged
1 commit merged into from
Jun 5, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jun 2, 2022

Description

Retrieval of the previous summary date from another date didn't work as expected.
This PR fixes this.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Author

ghost commented Jun 2, 2022

@ghost ghost force-pushed the 06-02-Fix_previous_summary_from_summary_timer branch from 20de227 to 96831c4 Compare June 2, 2022 14:28
@ghost ghost added bug Something isn't working beacon chain Involve BeaconChain labels Jun 2, 2022
@ghost ghost marked this pull request as ready for review June 2, 2022 14:58
@ghost ghost assigned blackode and unassigned blackode Jun 2, 2022
@ghost ghost requested a review from blackode June 2, 2022 15:04
@ghost ghost self-assigned this Jun 2, 2022
@ghost ghost changed the base branch from 06-02-Write_transaction_to_specific_genesis_address to develop June 2, 2022 15:55
@ghost ghost requested a review from imnik11 June 3, 2022 08:29
@ghost ghost added the core team Assigned to the core team label Jun 3, 2022
@ghost ghost removed the request for review from blackode June 3, 2022 10:15
@ghost ghost merged commit 8854781 into develop Jun 5, 2022
@ghost ghost deleted the 06-02-Fix_previous_summary_from_summary_timer branch June 5, 2022 17:47
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beacon chain Involve BeaconChain bug Something isn't working core team Assigned to the core team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants