Skip to content
This repository has been archived by the owner on Jun 13, 2023. It is now read-only.

Change field searches to use fields instead of handlers #45

Closed
ruebot opened this issue Oct 8, 2018 · 2 comments
Closed

Change field searches to use fields instead of handlers #45

ruebot opened this issue Oct 8, 2018 · 2 comments
Assignees

Comments

@ruebot
Copy link
Member

ruebot commented Oct 8, 2018

If we do something similar to what @anjackson did in this commit, we'd leave less of a burden on the implementer to setup a custom solrconfig.xml like we ship here, and if they already have a Solr index two setup with the same or similar schema.xml that webarchive-discovery ships, it would be an easier drop-in.

config.add_search_field 'title', label: 'Title' do |field|
field.qt = 'title_search'
end
config.add_search_field 'content', label: 'Content' do |field|
field.qt = 'content_search'
end
config.add_search_field 'url', label: 'URL' do |field|
field.qt = 'url_search'
end
config.add_search_field 'host', label: 'Host' do |field|
field.qt = 'host_search'
end

Less things to maintain?

@anjackson @ianmilligan1 let me know what you think.

@ruebot ruebot self-assigned this Oct 8, 2018
@ianmilligan1
Copy link
Member

I'm far from a Solr expert, so I'd defer to you and @anjackson, but going down this route makes perfect sense to me!

@ruebot
Copy link
Member Author

ruebot commented Oct 11, 2018

After some good discussion in IIPC webarchive-discovery channel, I'm going to move forward with this. It'll make Warclight easier to implement for webarchive-discovery users.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants