Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scripting hook get_urls() should support setting inline, post_data #25

Closed
chfoo opened this issue Jan 30, 2014 · 0 comments
Closed

Scripting hook get_urls() should support setting inline, post_data #25

chfoo opened this issue Jan 30, 2014 · 0 comments
Assignees
@chfoo
Labels
enhancement

Comments

@chfoo
Copy link
Member

chfoo commented Jan 30, 2014

Currently scripts return a list of dicts for get_urls() which are considered "linked" and not "inline". As well they need to support post data.

The new supported keys should be:

  • inline: boolean
  • post_data: string

Post data depends on #8.
chfoo added a commit that referenced this issue Feb 1, 2014
@chfoo
hook: Accepts inline, link_type for get_urls() (#25).
0a5a273 
Moves Callbacks.to_native_type to HookEnvironment.to_script_native_type.
@chfoo chfoo closed this as completed in 78f259e Feb 1, 2014
@chfoo chfoo self-assigned this Mar 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chfoo chfoo

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chfoo