Upstream some Alpm methods
#30
Conversation
|
Right. I don't really know how this ended up like this. I think I have have just been experimenting and accidentally committed the file I don't know. |
alpm-utils/src/alpm.rs
Outdated
| /// | ||
| /// An orphan is a package that was installed as a dependency, but whose parent | ||
| /// package is no longer installed. | ||
| pub fn orphans(alpm: &Alpm) -> impl Iterator<Item = Package<'_>> { |
There was a problem hiding this comment.
This is too opinionated to belong here IMO. This won't watch dependency cycles, an issue pacman also suffers from.
There was a problem hiding this comment.
required_by wouldn't be enough to cover the cyclic dependency case?
| name: S, | ||
| version: V, | ||
| ) -> bool { | ||
| pub fn satisfies_dep<S: AsRef<str>, V: AsRef<Ver>>(dep: impl AsDep, name: S, version: V) -> bool { |
There was a problem hiding this comment.
Have you got some custom cargo fmt config?
There was a problem hiding this comment.
I don't, but the last changes to these lines occurred in 2019, so there's a chance that rustfmt changed since then.
|
Looks like my email message didn't get delivered to the PR for some reason. Oh well. Anyway I was on vacation for a few days; fixing this now. |
|
Should be good to go now. |
|
Is this okay to merge? |
|
Any further thoughts? |
alpm-utils/src/alpm.rs
Outdated
| pub trait AlpmExt { | ||
| fn find_local_satisfier<S: Into<String>>(&self, pkg: S) -> Result<Option<Package>>; | ||
| } | ||
| /// All official packages. |
There was a problem hiding this comment.
There's no concept off "official" packages. Comment should describe the concept of packages that can also be found in a syncdb.
alpm-utils/src/alpm.rs
Outdated
| return Ok(Some(alpm_pkg)); | ||
| } | ||
| } | ||
| /// All foreign packages as an `Iterator`. |
There was a problem hiding this comment.
Same as above but the opposite.
|
Sorry bit busy. Also you removed the alpmext trait (even though it was dead code anyway). I think the trait should remain and these methods be on it. Especially if one day I wish to add these functions back. |
|
Roger, no problem. Busy here too, settling into a new job in a new country. |
|
Hey Morgan, just out of town for a few days, I’ll fix this up once I’m back.
iPhoneから送信
… 2022/08/20 18:34、Lulu ***@***.***>のメール:
Right. I don't really know how this ended up like this. I think I have have just been experimenting and accidentally committed the file I don't know.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.
|
This required fixing `find_local_satisfier` which wasn't compiling. This module had been previously left out of the module tree, so the broken code was never compiled and thus never detected.
And rename a few functions.
This required implementing some custom iterator structs, since `impl Foo` is not allowed for the return types of trait methods.
fosskers
force-pushed
the
colin/alpm-extensions
branch
from
ff025a5
to
4be3dee
Compare
|
Finally updated! |
This PR upstreams some local functionality I've had for a while, but it's better suited to live here than in Aura.