Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting profiles require a least one profile to be given as an option #59

Closed
kpcyrd opened this issue Oct 29, 2020 · 5 comments
Closed
Assignees

Comments

@kpcyrd
Copy link
Member

kpcyrd commented Oct 29, 2020

image

I got this error after following the install instructions from the readme:

pip install archinstall
python -m archinstall guided

I also accidentally booted into BIOS mode, but retrying in EFI gives me the same error.

@Torxed
Copy link
Member

Torxed commented Oct 30, 2020

@kpcyrd That is an interesting error, it means that the profile selector could not locate any profiles. Did you configure the network properly on the machine? Or you booted straight into a pre-prepared ISO?

If this was indeed the issue, I should most definitely create a "startup check" that notifies users about pre-requisites prior to sending them to the select-option stage.

@kpcyrd
Copy link
Member Author

kpcyrd commented Oct 30, 2020

The network is working correctly, I've used the regular arch iso and installed archinstall with pip install archinstall. :)

@Torxed
Copy link
Member

Torxed commented Oct 30, 2020

Awesome, thank you for the feedback. Will test it out and see what the issue might be!

@Torxed Torxed self-assigned this Oct 30, 2020
@Torxed
Copy link
Member

Torxed commented Nov 1, 2020

Found the issue, it's simply a confusion in the code where cwd is during execution.
Trying to isolate which commit caused this issue as it has been working before. Just to be sure the fix doesn't interrupt any logic I've introduced since then : )

Problem: https://github.com/Torxed/archinstall/blob/master/archinstall/lib/profiles.py#L24

Torxed added a commit that referenced this issue Nov 1, 2020
Relative paths work great for running as a script.
But break when running as a module since there is no `src/` folder to mention.
This should clear that up as the `src/` now lives under wherever the python package was installed.
@Torxed
Copy link
Member

Torxed commented Nov 1, 2020

I think that resolves it, works in the test environment at least.
If the issue still exists, I'd be happy to re-open and continue digging : )

(pypi upload will commence shortly, with a new version release with some other fixes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants