Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profiles are not working with "No such file or directory" #62

Closed
Torxed opened this issue Nov 9, 2020 · 3 comments
Closed

Profiles are not working with "No such file or directory" #62

Torxed opened this issue Nov 9, 2020 · 3 comments
Assignees
@Torxed
Labels
bug Something isn't working

Comments

@Torxed
Copy link
Member

Torxed commented Nov 9, 2020

Imported profiles doesn't work with URL's.
Root cause is Profile.load_instructions() which gives the URL as a file name.

The reason for this bug is when run in module-mode, the working path is wonky (will look at it) and there for it resorts back to HTTP-lookup.

image
@Torxed Torxed added the bug Something isn't working label Nov 9, 2020
@Torxed Torxed self-assigned this Nov 9, 2020
@Torxed Torxed pinned this issue Nov 9, 2020
@Torxed
Copy link
Member Author

Torxed commented Nov 9, 2020

Fix is relatively easy, either correct the working directory, or a more long term fix is to start using the Script approach with temp files instead.

@Torxed Torxed mentioned this issue Nov 11, 2020
Closed
Torxed added a commit that referenced this issue Nov 29, 2020
@Torxed
Trying to combat #62. By implementing a UPSTREAM_URL variable globall…
4f2a637 
…y, which can be controlled, as well as a PROFILE_PATH which controls where it should look for profiles. the list_profiles() should be more robust.
@Torxed Torxed closed this as completed in 607de55 Nov 29, 2020
@Torxed Torxed reopened this Nov 29, 2020
Torxed added a commit that referenced this issue Nov 29, 2020
@Torxed
Lowering MAC addresses for file-name comparison against local mac add…
4d153c5 
…resses in #62
Torxed added a commit that referenced this issue Nov 29, 2020
@Torxed
Merging in find_installation_script() into Script() for a more unifie…
817465b 
…d handler of any given script type or location. Which should correct #62.
Torxed added a commit that referenced this issue Nov 29, 2020
@Torxed
Forgot to replace URL schemes from temporary path. #62
8814cb4
@Torxed
Copy link
Member Author

Torxed commented Nov 29, 2020

Think that does it, going through testing right now for three main usages:

  • python -m archinstall https://archlinux.life/FE-00-00-00-00-00.py - Direct URL to profile
  • python -m archinstall guided for template lookup under examples/
  • python -m archinstall /path/to/guided.py for direct path to profile

@Torxed
Copy link
Member Author

Torxed commented Dec 6, 2020

Fixed in v2.0.6.
Any outstanding issues deserve a ticket of their own : )

@Torxed Torxed closed this as completed Dec 6, 2020
@Torxed Torxed unpinned this issue Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Torxed Torxed

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Torxed