Added enum 'All open-source (default)' for compatibility with older config versions #2176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
ghost
changed the title
ghost
changed the title
|
This seems to be a bit of a dangerous syntax, we're making one of the enum types a tuple. Can we handle this in a more elegantand explicit way |
|
Changed to condition which updates value from old configuration files |
|
Sorry for the inconvenience; should have created an issue highlighting an optional backward compatability addition for that field. |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old configuration versions of archinstall when choosing graphics drivers look for
All open-source (default)value. Current enum value hasAll open-sourcevalue.Fix should make older versions of archinstall configurations compatible with new version of enum.