Add Neoverse N2 #112
Merged
Add Neoverse N2 #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @alalazo, I was wondering if you have had the time to have a look at the proposal? Thanks |
alalazo
requested changes
Jul 5, 2024
|
I assume this one supersedes #105, so let's continue working here. Can you rebase? Other than that this looks fine. |
This patch adds a new test target for neoverse_n2 as a proof of concept.
|
HI @alalazo , have rebased and pushed to the branch. Thanks |
alalazo
previously approved these changes
Jul 9, 2024
alalazo
reviewed
Jul 9, 2024
alalazo
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #97
This patch goes together with archspec/archspec#170 . Similarly to that PR, this PR is intended to be a proposal on how to use the cpuid field to identify candidates on aarch64 architectures.
This patch introduces an example of neoverse_n2 example (in the test folder) and the neoverse_n2 in the microarchitectures.json. The addition in the json file would overwrite #105 but, as this PR is intended to be a proposal, I'll carefully manage it if PR#105 gets merged in first.
Warning: This patch has not removed the SM crypto features from the neoverse_v2 definition yet.
CC: @dslarm, @alalazo