Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 64 - Removed thrust #66

Merged
merged 3 commits into from
Jun 19, 2017
Merged

Issue 64 - Removed thrust #66

merged 3 commits into from
Jun 19, 2017

Conversation

AndresSanchezCuadrado
Copy link
Contributor

Thrust have been removed.

Notice that it has been removed also from README.md and CREDITS.txt files.

The CUDA test will not work.

jdgarciauc3m
jdgarciauc3m requested changes Jun 16, 2017
View reviewed changes
Copy link
Contributor

@jdgarciauc3m jdgarciauc3m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GRPPI_CUDA_ENABLE should be removed from all cmake files.

jdgarciauc3m
jdgarciauc3m reviewed Jun 18, 2017
View reviewed changes
Copy link
Contributor

@jdgarciauc3m jdgarciauc3m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CUDA tests should also be removed.

@jdgarciauc3m jdgarciauc3m modified the milestone: v0.2 Jun 18, 2017
jdgarciauc3m
jdgarciauc3m requested changes Jun 19, 2017
View reviewed changes
Copy link
Contributor

@jdgarciauc3m jdgarciauc3m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests making use of cuda should also be removed.

jdgarciauc3m
jdgarciauc3m approved these changes Jun 19, 2017
View reviewed changes
Copy link
Contributor

@jdgarciauc3m jdgarciauc3m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We finally remove all CUDA dependency.

CUDA support will come back in v0.3

@jdgarciauc3m jdgarciauc3m merged commit ec801b3 into latest Jun 19, 2017
@jdgarciauc3m jdgarciauc3m deleted the issue-64 branch June 19, 2017 08:30
@jdgarciauc3m jdgarciauc3m mentioned this pull request Jun 19, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdgarciauc3m jdgarciauc3m jdgarciauc3m approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@AndresSanchezCuadrado @jdgarciauc3m