App config handling with JSON/YAML de/encoder and builder #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
arcticicestudio
commented
Jun 25, 2019
arcticicestudio
commented
The `internal/util` package provides application-wide utility functions. The initial implementations are scoped for filesystem actions like checking if a file exists at a given path (and is not a directory) as well as ensuring absolute paths and necenssary write permissions. Epic GH-33 Depends on GH-58 GH-60
The `pkg/config` package provides the application-wide configuration struct and constants. The subpackage `pkg/config/encoder` provides the `Encoder` interface that is implemented in the `pkg/config/encoder/json` and `pkg/config/encoder/yaml` packages to handle the de/encoding of JSON and YAML data. To process the data from files the `File` struct of the `pkg/config/source/file` package represents an abstractation to validate and load data from files on the local filesystem. To simplify the usage and handling of configurations the `pkg/config/builder` package provides the `Load` and `Merge` functions by using the builder design pattern in order to allow to chain both functions. References: (1) (2) Epic GH-33 Depends on GH-58 Resolves GH-60
svengreb
approved these changes
Jun 25, 2019
arcticicestudio
deleted the
feature/gh-60-app-config-and-file-encode-builder
branch
arcticicestudio
added a commit
that referenced
this pull request
Jun 25, 2019
* Internal filesystem utility functions The `internal/util` package provides application-wide utility functions. The initial implementations are scoped for filesystem actions like checking if a file exists at a given path (and is not a directory) as well as ensuring absolute paths and necenssary write permissions. Epic GH-33 Depends on GH-58 GH-60 <---------------------------------------------------------------------> * App config handling with JSON/YAML de/encoder and builder The `pkg/config` package provides the application-wide configuration struct and constants. The subpackage `pkg/config/encoder` provides the `Encoder` interface that is implemented in the `pkg/config/encoder/json` and `pkg/config/encoder/yaml` packages to handle the de/encoding of JSON and YAML data. To process the data from files the `File` struct of the `pkg/config/source/file` package represents an abstractation to validate and load data from files on the local filesystem. To simplify the usage and handling of configurations the `pkg/config/builder` package provides the `Load` and `Merge` functions by using the builder design pattern in order to allow to chain both functions. Epic GH-33 Depends on GH-58 Resolves GH-60
arcticicestudio
added a commit
that referenced
this pull request
Jun 26, 2019
* Internal filesystem utility functions The `internal/util` package provides application-wide utility functions. The initial implementations are scoped for filesystem actions like checking if a file exists at a given path (and is not a directory) as well as ensuring absolute paths and necenssary write permissions. Epic GH-33 Depends on GH-58 GH-60 <---------------------------------------------------------------------> * App config handling with JSON/YAML de/encoder and builder The `pkg/config` package provides the application-wide configuration struct and constants. The subpackage `pkg/config/encoder` provides the `Encoder` interface that is implemented in the `pkg/config/encoder/json` and `pkg/config/encoder/yaml` packages to handle the de/encoding of JSON and YAML data. To process the data from files the `File` struct of the `pkg/config/source/file` package represents an abstractation to validate and load data from files on the local filesystem. To simplify the usage and handling of configurations the `pkg/config/builder` package provides the `Load` and `Merge` functions by using the builder design pattern in order to allow to chain both functions. Epic GH-33 Depends on GH-58 Resolves GH-60
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.