Update abstract repository documentation #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ardalis
reviewed
Jan 13, 2022
| { | ||
| var spec = new HeroByNameSpec(name); | ||
|
|
||
| return await repository.GetBySpecAsync(spec); |
There was a problem hiding this comment.
At this point in reading this I want to know what happens if there are 2 heroes with this same name...
There was a problem hiding this comment.
described how GetBySpecAsync would handle this above
ardalis
reviewed
Jan 13, 2022
|
|
||
| public async Task<Hero> GetById(int id) | ||
| { | ||
| return await repository.GetByIdAsync(id); |
There was a problem hiding this comment.
It's probably worth noting the type of repository somewhere in this section.
ardalis
reviewed
Jan 13, 2022
| ```csharp | ||
| public class HeroService | ||
| { | ||
| private readonly YourRepository<Hero> repository; |
There was a problem hiding this comment.
I see it here. Normally I would make a private field _repository. In any case maybe show this line up above so folks know what type it is before getting here.
There was a problem hiding this comment.
mentioned the field above and changed the field name
ardalis
reviewed
Jan 13, 2022
Co-authored-by: Steve Smith <steve@kentsmiths.com>
ardalis
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #206