-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improved ts config, fixed types, insttead of PR 404 #407
base: master
Are you sure you want to change the base?
Conversation
@beerose some issues with yarn install |
I've updated eslint plugins versions only |
@beerose please approve 5 workflows |
I've created a PR in ardatan/whatwg-node#391 to fix extends conflict. |
@JustFly1984 I see some checks are failing — could you take a look at it? |
We need to skip e2e workflows for forks in the workflow configuration because they use env vars that are unavailable to forks. So it is ok to ignore them for now. Besides that, I think this PR is blocked by the one in whatwg-node right? |
@ardatan you are correct, we have to resolve whatwg-node issue first. |
🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.
Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of
the pull request.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant
motivation and context. List any dependencies that are required for this change.
Related # (issue) #402
Type of change
Please delete options that are not relevant.
expected)
Screenshots/Sandbox (if appropriate/relevant):
Adding links to sandbox or providing screenshots can help us understand more about this PR and take
action on it as appropriate
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can
reproduce. Please also list any relevant details for your test configuration
Test Environment:
package-name
:Checklist:
CONTRIBUTING doc and the
style guidelines of this project
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose
the solution you did and what alternatives you considered, etc...