Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix documentation of createRouter params #907

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Fix documentation of createRouter params #907

merged 2 commits into from
Dec 7, 2023

Conversation

adriencohen
Copy link
Contributor

Description

Fix outdated documentation of createRouter due to swaggerUiEndpoint and oasEndpoint being moved to a different place in the params.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests and linter rules pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ardatan
Copy link
Owner

ardatan commented Dec 7, 2023

Thanks for the PR!

@ardatan ardatan merged commit 2f4f9c8 into ardatan:master Dec 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ardatan ardatan ardatan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adriencohen @ardatan