-
-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance(printSchemaWithDirectives): for code first schemas #2391
Conversation
🦋 Changeset detectedLatest commit: 3b054ff The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest changes of this PR are available as alpha in npm (based on the declared
|
6990e78
to
faf4ca3
Compare
so you can use mapSchema within printSchemaWithDirectives without going into infinite recursion
actually did not end up using mapSchema
c013659
to
5eb8fad
Compare
Would appreciate when you have time to take a look at these changes. Motivation for these changes is to allow code-first schemas to use directives within extensions so they can embed metadata for stitching. These changes will allow printing of directive definitions that are without SDL and directive uses embedded within extensions. There are some changes here to printSchemaWithDirectives that I am not completely sure about => specifically the use of I also ended up fixing an infinite recursion issue with |
GraphQL directives defined without an astNode should be converted to as astNode/print.
GraphQL directives found in extensions should be converted to astNodes/print.