-
-
Notifications
You must be signed in to change notification settings - Fork 815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disallow new lines in paths when checking with isValidPath
#6055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fe69bff The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
14 tasks
✅ Benchmark Results
|
💻 Website PreviewThe latest changes are available as preview in: https://12938a9d.graphql-tools.pages.dev |
enisdenjo
changed the title
isValidPath assumes non-paths are paths
Disallow new lines in paths when checking with Apr 12, 2024
isValidPath
enisdenjo
added a commit
to ardatan/graphql-mesh
that referenced
this pull request
Apr 12, 2024
ardatan
approved these changes
Apr 15, 2024
enisdenjo
added a commit
to ardatan/graphql-mesh
that referenced
this pull request
Apr 15, 2024
enisdenjo
added a commit
to ardatan/graphql-mesh
that referenced
this pull request
Apr 15, 2024
enisdenjo
added a commit
to ardatan/graphql-mesh
that referenced
this pull request
Apr 16, 2024
enisdenjo
added a commit
to ardatan/graphql-mesh
that referenced
this pull request
Apr 16, 2024
ardatan
added a commit
to ardatan/graphql-mesh
that referenced
this pull request
Apr 16, 2024
* e2e setup * prepare and setup * cjs * should start mesh * improved utils * available port and stuff * use tsx cjs loader * test compose and waitforexit reject * fix compose * e2e test ci * chore(dependencies): updated changesets for modified dependencies * sync getavailport * e2e node matrix * changeset * serve script * tenv and stuff * tenv args and serve helper * tenv only serve and compose * esm config in cjs project * simplify and use 0.0.0.0 * more details * extend proc and less listners * stderr for logs, stdout for outputs * stable tenv std * compose to stdout * unnecessary serve script * more wait for serve * stable stderr * compose to target * simpler match for stability * actually check stuff * update snapshots * snapshot file * unnecessary port * use 0.0.0.0 * unnecessary comment * allow nodejs modules in e2e * better args * refactor and begin with type merging batching example * increase timeout * open example * clarify * link * lol * lol * even more lol * test plans * WIP spawn detached and kill whole process group * improve child process handling and use node with tsx for subgraphs * stop reachability wait after exit * append new line when logging to stderr * nobuild e2e * utils mkdir independant of fs * type merging batching planning tests run concurrently * execution tests * check for aborted on retry * touches * fix(fusion/query-planner): skip the resolver if it has required variables that the parent subgraph doesn't have * update snaps * unnecessary assers * listen to stderr * subgraphs -> services * service can be in <name>/index.ts * thrift-calculator * sqlite-chinook * lockfile * serveoptions * ensure compose creates file * tenv serve.execute * just fusiongraph * rest transport explicit type export * openapi-javascript-wiki * simpler doc * tenv composition target is temp * use target's absolute path if detected * unused import * increase reachability wait timeout even more * try less workeser * await available port making sure the server closes * maxConcurr * use __project * wait for reachability longer * disposable * waitforexit is internal * tenv containers and waiting adjustments * mysql-employees * mysql-employees no dates * neo4j-example * detectopenhandles * args type leak from cjs-project * auto-type-merging * timeout e2e tests because of open handles * batching-resolver * federation-example * unnecessary delay * federation example servers * soap-demo * openapi-subscriptions * no example queries * revert prettierpath * tfetch not necessary * unnecessary deferstream plugin * openapi v3 petstore * mysql-rfam * batching resolver simpler api service * lockfile * json-schema-subscriptions * fusiongraph is not necessary * json-schema-reddit * neo4j uses serve and pubsub * make sure the pubsub is destroyed * mysql-rfam pubsub * lockfile * use ardatan/graphql-tools#6055 * chore(dependencies): updated changesets for modified dependencies * specify endpoint for petstore * auto-type-merging use container petstore * use stable release of utils * chore(dependencies): updated changesets for modified dependencies * Fix federation example * no skipping * no dates in snaps * Changeset * update snap relating to a720512 * json-schema-reddit example * use stable release of utils * chore(dependencies): updated changesets for modified dependencies --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Arda TANRIKULU <ardatanrikulu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A string may sometimes look like a path but is not (like an SDL of a simple GraphQL schema). To make sure we don't yield false-positives in such cases, we disallow new lines in paths (even though most Unix systems support new lines in file names).
An example of a false-positive: