Change read to return up to available bytes #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of returning buffered data size
Also only call recvfrom if there is more data in the currently parsed packet and make read() call read(unsigned char* buf, size_t size), to remove duplication.
…e()" This reverts commit 06a6a7f.
|
I've updated the pull request based on @ThibaultRichard's comment sandeepmistry@06a6a7f#commitcomment-14252712 |
|
Works perfectly with both AVR and 101 boards 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2.
Before read was only returning bytes that were buffered, instead of all the bytes in the parsed packet.
Also, changed available to return the bytes available in the current parsed packet, as per API spec. Previously, it was return bytes available in the buffer, if it was smaller than the packet size.
cc/ @cmaglie @facchinm