fast serialUSB read function readBlock #4871
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| buffer->head = i; | ||
|
|
||
| i = (i + 1) % CDC_SERIAL_BUFFER_SIZE; | ||
| uint8_t c[CDC_SERIAL_BUFFER_SIZE]; |
There was a problem hiding this comment.
You are overwriting the c variable above. Remove it or rename the array.
sandeepmistry
added
Architecture: SAM
|
Moved to arduino/ArduinoCore-sam#3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main idea is that bytes are written and read into/from CDC buffer not one by one but block of bytes.
Serial_::accept write into CDC buffer as maximum as possible (only to not overflow the buffer)
Serial_::readb (you can change just read, not use readb) get from CDC buffer as maximum as possible or nessasary length
and one more important thing: in USBD_Recv "while (n--) *dst++ = UDD_Recv8(ep & 0xF);" should be replaced into UDD_Recv(ep & 0xF, dst, len);
after that read speed is incredible increases !!! Up to 12Mbit/s