Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[grpc] Revisit the PlatformRelease#type naming (or typing) #2504

Closed
3 tasks done
kittaakos opened this issue Jan 17, 2024 · 0 comments · Fixed by #2620
Closed
3 tasks done

[grpc] Revisit the PlatformRelease#type naming (or typing) #2504

kittaakos opened this issue Jan 17, 2024 · 0 comments · Fixed by #2620
Assignees
Labels
conclusion: resolved Issue was resolved topic: gRPC Related to the gRPC interface type: enhancement Proposed improvement

Comments

@kittaakos
Copy link
Contributor

Describe the request

The PlatformRelease#type is a repeated field, still singular and not aligned with other repeated fields, such as boards

Describe the current behavior

The API property does not follow the naming convention. It should be named as types and have a repeated string type. Or keep the name, and use a string

Arduino CLI version

0.36.0-rc.1

Operating system

N/A

Operating system version

n/a

Additional context

As far as I know, the types array will always have one item. I propose keeping the repeated string type and adjusting the property name to types.

Issue checklist

  • I searched for previous requests in the issue tracker
  • I verified the feature was still missing when using the nightly build
  • My request contains all necessary details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved topic: gRPC Related to the gRPC interface type: enhancement Proposed improvement
Projects
None yet
3 participants