Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip changelog] Sync documentation assets with templates #1383

Merged
merged 4 commits into from
Aug 10, 2021
Merged

[skip changelog] Sync documentation assets with templates #1383

merged 4 commits into from
Aug 10, 2021

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Aug 10, 2021

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

Infrastructure update

  • What is the current behavior?

We have assembled a collection of reusable project assets:
https://github.com/arduino/tooling-project-assets
These assets will be used in the repositories of all Arduino tooling projects.

Some significant improvements and standardizations have been made to the documentation management system in the upstream "template" assets, but have not yet been pulled into this repository.

  • What is the new behavior?

Workflow is synced with the state of the art from upstream.

Notable changes:

  • Use markdownlint-cli to check for common problems and formatting
    • Bring ordered list prefixes into compliance with the standardized style
    • Use consistent code block syntax throughout all Markdown files
  • Make link check task Windows compatible
  • Streamline website versioning system
  • Use modern MkDocs versioning features
  • Make command reference generation task Windows compatible
  • Consolidate all Python dependency management to Poetry
  • Standardize documentation-related task names and remove old task names:
    • docs:gen:commands -> go:cli-docs
    • docs:gen -> docs:generate
    • docs:build -> docs:check
    • docs:serve -> website:serve
    • docs:check-links -> markdown:check-links
  • Does this PR introduce a breaking change, and is
    titled accordingly?

Does this PR introduce a breaking change

The changed task names might be disruptive to development work, but there are no breaking changes to the API.

is titled accordingly

Yes

  • Other information:

"Check Prettier Formatting" workflow run failure is unrelated to the changes made here: #1380 (comment)

Broken link check failure is expected. The badge link will become valid on the workflow run when this PR is merged. Equivalent URL from my fork:
https://github.com/per1234/arduino-cli/actions/workflows/deploy-cobra-mkdocs-versioned-poetry.yml/badge.svg

Demonstration "dev" website deployment:

Demonstration release website deployment:

@per1234 per1234 added type: enhancement Proposed improvement topic: documentation Related to documentation for the project topic: infrastructure Related to project infrastructure labels Aug 10, 2021
We have assembled a collection of reusable project assets:
https://github.com/arduino/tooling-project-assets
These assets will be used in the repositories of all Arduino tooling projects.

Some significant improvements and standardizations have been made in the upstream "template" assets, and those are
introduced to this repository here.

Notable:

- Use markdownlint to check for common problems and formatting.
- Make link check task Windows compatible
- Streamline website versioning system
- Use modern MkDocs versioning features
- Make command reference generation task Windows compatible
- Consolidate all Python dependency management to Poetry
- Standardize documentation-related task names and deprecate old task names
The sync with the template documentation assets has resulted in new standardized names for some of the documentation
management tasks:

- `docs:gen:commands` -> `go:cli-docs`
- `docs:gen` -> `docs:generate`
- `docs:build` -> `docs:check`
- `docs:serve` -> `website:serve`
- `docs:check-links` -> `markdown:check-links`
This is the standardized ordered list prefix for use in all Arduino Tooling Markdown files.

The Markdown renderer will automatically handle numbering. Manual numbering means that either all following list items
need to be renumbered every time a list item is added or removed, resulting in more work for contributors and reviewers.
"Code fencing" is superior to the indentation code block syntax of Markdown because it permits syntax highlighting. Even
in cases where syntax highlighting is not applicable, a consistent style should be used throughout all the Markdown files
of Arduino Tooling projects.
Copy link
Contributor

@silvanocerza silvanocerza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 💯

@per1234 per1234 merged commit f04d18f into arduino:master Aug 10, 2021
@per1234 per1234 deleted the docs branch August 10, 2021 14:26
@per1234 per1234 self-assigned this Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: documentation Related to documentation for the project topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants